Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Schema changes related to BEP032 #1826

Open
wants to merge 36 commits into
base: bep032
Choose a base branch
from

Conversation

ree-gupta
Copy link
Member

@ree-gupta ree-gupta commented May 17, 2024

  • BIDS BEP032 Proposal
  • Contributes to [ENH] microelectrode electrophysiology specification (BEP032) #1705
  • Related issue about age Formalize participants' age to clarify the reference point #1634
  • Clarify if columns can have arrays as value, if not, how do we handle the surgery_date
  • Add columns for _probes.tsv
  • Add tabular_data rules for _probes.tsv
  • Add columns for _electrodes.tsv
  • Add tabular_data rules for _electrodes.tsv
  • Add columns for _channels.tsv
  • Add tabular_data rules for _channels.tsv
  • Add columns for _scans.tsv --> not required as already inherited from main BIDS
  • Add tabular_data rules for _scans.tsv --> not required as already inherited from main BIDS
  • Add columns for _events.tsv
  • Add tabular_data rules for _events.tsv
  • Add sidecars rule for _coordsystem.json
  • Add sidecars rule for _ephys.json (except probe information as decision pending)
  • Fix language conventions, such as for e.g. -> for example,
  • Discuss and clear TODOs commented out in the schema
  • Add file naming and other modality-specific rules
  • Fix schema validation errors

@bids-standard/bep032

@ree-gupta ree-gupta changed the title [ENH] Schema changes related to particiapants.tsv for BEP032 [ENH] Schema changes related to participants.tsv for BEP032 May 17, 2024
@ree-gupta ree-gupta marked this pull request as ready for review May 17, 2024 11:03
@ree-gupta ree-gupta changed the title [ENH] Schema changes related to participants.tsv for BEP032 [ENH] Schema changes related to BEP032 May 27, 2024
@yarikoptic
Copy link
Collaborator

@ree-gupta Thanks again for working on this! Could you please "enable" pre-commit for you locally -- pre-commit install so then it would check/address problems before you even make/push a commit?

@ree-gupta
Copy link
Member Author

@ree-gupta Thanks again for working on this! Could you please "enable" pre-commit for you locally -- pre-commit install so then it would check/address problems before you even make/push a commit?

Sure thing! Thank you for the suggestion.

height__probes: optional
depth__probes: optional
dimension_unit: optional
alpha_rotation: recommended
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ree-gupta can you please delete this so it shows the latest changes google docs?

It is optional, and adding does not solve anything but makes it
consistent with the other files in the folder
@yarikoptic
Copy link
Collaborator

yarikoptic commented Oct 18, 2024

Took me awhile, even sent complimentary #1963 to see the obvious gotcha! ;) pushed the fix -- hopefully gets green now @ree-gupta ! Thanks again for working on this!!!

edit: CI is green where we care.

@ree-gupta
Copy link
Member Author

Took me awhile, even sent complimentary #1963 to see the obvious gotcha! ;) pushed the fix -- hopefully gets green now @ree-gupta ! Thanks again for working on this!!!

edit: CI is green where we care.

Thank you for spotting and fixing this @yarikoptic! 🙏🏽 the schema validation check passes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants