-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Additional age related columns for participants.tsv file to cover animal data #1839
base: master
Are you sure you want to change the base?
Conversation
What would be the best way to indicate that these fields are recommended for non-humans, but not recommended for humans? |
Besides birthday I think we can entirely avoid species-specificity here, but I liked phrasing to refer to units section on anonymization. I was looking at the stages and if someone annotates that it is late adult stage - it might help finding subjects of such interest. It is more of a question to me of duplicity of metadata, thus possibly leading to incongruities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slight tune ups
name: age_type | ||
display_name: Age type | ||
description: | | ||
Type of age measurement (e.g. `postnatal`, `fetal`, `gestational`). If not specified, `postnatal` is assumed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there some ontology or controlled vocab to reference here as well by any chance?
@lzehl says "No!"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if age_reference
, some time points to consider:
- fertilization
- birth
- gestation
- ...
it seems we are boiling down to establishing a list of Enums with clear definitions and possibly adding TermURLs for some of them where there is a clear association.
TODO also to formalize such "TermURL" like linking at the level of schema which seems to lack it ATM.
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
@bendichter @yarikoptic I agree that only birth_date causes issues with humans due to GDPR. This list is derived from the UBERON ontology where possible with small additions were needed. Note that openMINDS did not yet integrate all UBERON life cycle stages: age_type in addition to define the reference point of the age value is a good idea. I'm not sure if the ontology https://bioportal.bioontology.org/ontologies/FMA/?p=classes&conceptid=http://purl.org/sig/ont/fma/fma312872 suggested by @satra in #1634 is species independent defined (definitions are also very sparse in this ontology). |
@lzehl @yarikoptic @bids-standard/bep032 As discussed in our last meeting, one of my TODOs was to add enums for |
The PR adds columns for
age_category
,age_type
,birthdate
as discussed and suggested by @yarikoptic in #1826This is open for discussion.
Related issues:
@bids-standard/bep032