Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade absence of sub- folders to warning #1928

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yarikoptic
Copy link
Collaborator

I could be wrong but I think there is no strict and agreed upon requirement to require having sub- subfolders in BIDS specification. Although odd, thus warranting a warning, I think it is not strictly forbidden, and e.g. a BIDS dataset only with stimuli/ or derivatives/ or sourcedata might still be well legit BIDS dataset.

Check was added in b9ea963 likely just copying from prior node version of bids-validator. Asking @effigies for setting me straight ;)

I could be wrong but I think there is no strict and agreed upon requirement to
require having sub- subfolders in BIDS specification. Although odd, thus
warranting a warning, I think it is not strictly forbidden, and e.g. a BIDS
dataset only with stimuli/ or derivatives/ or sourcedata might still be well
legit BIDS dataset.
@effigies
Copy link
Collaborator

effigies commented Oct 3, 2024

The legacy validator errored on the absence of subject directories, so this was written for consistency with that.

I don't see the use-case for subject-less datasets. Calling a directory that contains opaque sourcedata/ and derivatives/ directories a BIDS dataset seems counter to the goal of BIDS, which is legible neuroimaging data. What's your goal?

With my OpenNeuro hat on, removing basic "are there any data?" checks, combined with mechanisms to shield data from validation, is just asking for turn into an arbitrary data hosting service. So this is just a note that, if this is demoted to a warning, we will need to promote it back to an error, and should probably go ahead and promote it just in case. cc @nellh

@yarikoptic
Copy link
Collaborator Author

I don't see the use-case for subject-less datasets. Calling a directory that contains opaque sourcedata/ and derivatives/ directories a BIDS dataset seems counter to the goal of BIDS, which is legible neuroimaging data. What's your goal?

immediate, although not mandatory if we do add dedicated DatasetType:

But also it is a matter of consistency: if there is such a rule it should be clearly described also in the specification, which I think is not the case ATM.

Indeed it might require openneuro specific configuration, but I thought you already have one anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants