Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP-85: formatting and changelog updates, and add word cases for application 39' #1691

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

akarve
Copy link
Contributor

@akarve akarve commented Oct 25, 2024

Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

bip-0085.mediawiki Show resolved Hide resolved
bip-0085.mediawiki Outdated Show resolved Hide resolved
@jonatack jonatack added the PR Author action required Needs updates, has unaddressed review comments, or is otherwise waiting for PR author label Nov 7, 2024
@akarve akarve requested a review from jonatack November 9, 2024 21:25
@jonatack jonatack added Proposed BIP modification and removed PR Author action required Needs updates, has unaddressed review comments, or is otherwise waiting for PR author labels Nov 14, 2024
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b398219

Only changes are presentation/formatting and adding two entries to the application 39' table.

@jonatack jonatack changed the title BIP-85: Move and reorder changelog to be near implementations, note 15' and 21' word cases for application 39' BIP-85: formatting and changelog updates, and add word cases for application 39' Nov 14, 2024
@jonatack jonatack merged commit 16a23b7 into bitcoin:master Nov 14, 2024
4 checks passed
@akarve akarve deleted the bip85-details branch November 14, 2024 02:26
@bitcoin bitcoin deleted a comment from Karthik-0521 Nov 14, 2024
@bitcoin bitcoin deleted a comment from Karthik-0521 Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants