Ephemeral returns #44
Conversation
|
@ameba23 Did a quick review of this. Apologies if some things I said are naive. Overview of thoughts:
|
recover/async/mend.js
Outdated
| if (shareVersion === '1.0.0' || !isBoxedMessage(shard.share)) { | ||
| cb(null, shard.share) | ||
| } else { | ||
| const dbKey = JSON.stringify({ rootId, recp: shard.feedId }) |
|
so i've almost made all the proposed changes, but stuck on making a reduce function async in the recobine tests i have to mention @mixmix, that dealing with this labyrinth of tests has been by far the most time-consuming part of adding ephemeral keys to returns. |
|
Generally the primary function of tests is to make sure we're alerted to any breaking changes, and often the largest part of the work is updating tests. They're there for a good reason. We don't want bad code ending up in here, particularly if we're dealing with secure information. I'll have a look at that particular test when I've got a moment. |
|
following @dominictarr 's security review of ssb-ephemeral-keys, that module is changing quite a bit (see this conversation. Specifically the module will use flat files rather than level to store ephemeral keys, to make them easier to securely delete. see this pr |
Ephemeral returns updated
Use ephemeral-keys for returning shards