-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ephemeral returns #44
Open
ameba23
wants to merge
64
commits into
master
Choose a base branch
from
ephemeral_returns
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 41 commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
4f73657
generate an eph key and include it in requests
ameba23 b6c736d
encrypt returned shards
ameba23 69fced9
temporarily disable validating shards, and encrypted ones wont pass
ameba23 74653ae
reply test
ameba23 1336ef2
recombinetest
ameba23 8728bf3
use sbot plugin for tests
ameba23 95e3cdc
use plugin, begin decryption in recover.async.mend (not yet working)
ameba23 caa56c3
mend takes server
ameba23 32c9cdb
stringify dbKey
ameba23 5c85d7f
fix bug and improve method
ameba23 90fd9a9
pass server to v1 forward test
ameba23 4c2ead0
pass server to v2 forward test
ameba23 0855974
pass server to v1 request test
ameba23 3bd7f31
pass server to v2 request test
ameba23 07ad245
include ephemeral keys generation and encryption in fetch/mend v2 test
ameba23 fdb4f30
omit ephemeral key decryption from v1 shards
ameba23 f2a8f22
isReply checks for boxed message
ameba23 8403608
add generateAndStore to additional v2 reply test
ameba23 3b91518
remove debug logging
ameba23 24833a2
lint
ameba23 8a127b9
use regex for testing .box suffix
ameba23 653e27d
method for deleting an ephemeral keypair
ameba23 d8d2c09
test for method for deleting an ephemeral keypair
ameba23 2e8f7ac
readme
ameba23 37dab83
improve recover.pull.replies
ameba23 92ba441
method to delete all ephemeral keypairs associated with a given rootid
ameba23 f1c7dd4
include deleteKeyPairs method in readme
ameba23 f052e61
expose deleteKeyPairs method
ameba23 6c75134
improve contextMessage in recover.async.mend
ameba23 17334fe
improve contextMessage in recover.async.reply
ameba23 a6b2d21
update contextMessage in tests
ameba23 f9c6ff0
remove additional logging
ameba23 b3961b9
handle non-boxed shards
ameba23 717c293
Merge pull request #49 from blockades/improve_ephemeral_returns
ameba23 fae55cb
remove fn from mend
ameba23 30249e8
merge conflict
ameba23 3bb58da
comments, additional test for deleteKeyPairs
ameba23 a2cf5ee
update testbot for renamed module
ameba23 ee1e357
update PLUGIN_DEPS for ephemeral keys plugin
ameba23 a326b31
add ssb-ephemeral-keys as a dev dependency
ameba23 4c93341
deleteKeyPair returns true if successful
ameba23 dae6624
tidy comments
ameba23 1f22c81
change to using async boxmessage
ameba23 ba838dd
remove stringify from dbkeys as it is done in the plugin
ameba23 26ba6bd
rename isBoxedMessage
ameba23 86d0b21
rename deleteEphemeralKeypairs
ameba23 e3ab3ab
rename variable in test
ameba23 98d17ed
rename tests, fix test for async boxMessage
ameba23 4af79ed
rename deleteEphemeralKeypairs
ameba23 f702f77
more renaming
ameba23 e3a68f8
yet more renaming
ameba23 634771e
update readme
ameba23 60ff58d
fix test for async boxmessage
ameba23 81fbb4a
fix fetch test for async boxmessage
ameba23 a770eac
fix boxMessage in reply.js
ameba23 0c9cf96
change variable name
ameba23 e61efc6
fixed request v2 test to work with async box method
ameba23 a1fe05b
bump ssb-ephemeral-keys
ameba23 af46260
fix merge conflicts
ameba23 035bd98
modify test for deleting a single ephemeral keypair for obligatory co…
ameba23 7ee8c37
modify test for deleting all ephemeral keypairs for obligatory contex…
ameba23 d6883ad
likewise for unboxing
ameba23 dc90ec9
bump ssb-ephemeral-keys
ameba23 acff648
Merge pull request #57 from blockades/ephemeral_returns_updated
ameba23 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for the moment, but we should be able to prove this is a boxed message using a better means. checking if there's
.box
at the end isn't reliable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few people recently have reported problems with isCanaonicalBase64 recently which is why i hesistated to use it. there is a regex for encrypted messages in ssb-schema-definitions but @mixmix trimmed it to only check for the .box suffix after having problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recommend rename this
isBoxedShard
to remove confusion about this being the content of a message being boxed... ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or rather
isBoxedShare
because the shard is a shard message, and ashare
is the piece which is actually being looked at, then it's in line withshareVersion
and makes more sense overall I think