Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IdleCircuit instance for Jtag Protocol #36

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Add IdleCircuit instance for Jtag Protocol #36

merged 2 commits into from
Sep 18, 2024

Conversation

lmbollen
Copy link
Contributor

I'm not entirely sure if we want the active low reset to be 0 here.

@lmbollen lmbollen mentioned this pull request Sep 18, 2024
Draft
martijnbastiaan
martijnbastiaan approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@martijnbastiaan martijnbastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure if we want the active low reset to be 0 here.

That's perfectly fine :)

@lmbollen lmbollen merged commit 0ac4a4f into main Sep 18, 2024
8 checks passed
@lmbollen lmbollen deleted the lucas/add-Jtag-Idle branch September 18, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnbastiaan martijnbastiaan martijnbastiaan approved these changes

@hydrolarus hydrolarus Awaiting requested review from hydrolarus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmbollen @martijnbastiaan