Improve frame rate limiting #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some cameras default to automatic frame rate mode when power-cycled. This makes the acquire period limitation ineffective, as the parameter is ignored by the camera firmware. Enforce manual frame rate setting at IOC start-up when limiting frame rate. Note that the overwritten record already contains `PINI=YES` to write this to hardware on `iocInit`. Fixes: d5caf77 ("database: add option to limit camera frame rate.")
henriquesimoes
force-pushed
the
limits
branch
2 times, most recently
from
a33d147
to
2d3aa06
Compare
Both AcquirePeriod and FrameRate can be used to define frame rate. Keep their limits consistent by forwarding the inverse of period limit to the FrameRate record. A better implementation of this feature would to have a FrameRateLimit record which forwards for both AcquirePeriod's and FrameRate's DRVL and DRLH fields. Having the limit specified in terms of frame rate would however would require changing the configuration parameter defined in the template st.cmd. To keep backward compatibility, the frame rate is computed based on the value of the AcquirePeriod.DRVL instead. Changing it at runtime requires reprocessing FrameRateLimitFwd to forward to FrameRate.DRVH.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frame rate limits have been improved to also be applicable to
FrameRatePV and ensure camera mode is set to use manually configurable frame rate.