Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve frame rate limiting #8

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Improve frame rate limiting #8

merged 2 commits into from
Apr 24, 2024

Commits on Apr 24, 2024

  1. database: ensure frame rate is enabled when limiting it.

    Some cameras default to automatic frame rate mode when power-cycled.
    This makes the acquire period limitation ineffective, as the parameter
    is ignored by the camera firmware.
    
    Enforce manual frame rate setting at IOC start-up when limiting frame
    rate. Note that the overwritten record already contains `PINI=YES` to
    write this to hardware on `iocInit`.
    
    Fixes: d5caf77 ("database: add option to limit camera frame rate.")
    henriquesimoes committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    94b5c87 View commit details
    Browse the repository at this point in the history
  2. database: forward rate limit to FrameRate.DRVH.

    Both AcquirePeriod and FrameRate can be used to define frame rate. Keep
    their limits consistent by forwarding the inverse of period limit to the
    FrameRate record.
    
    A better implementation of this feature would to have a FrameRateLimit
    record which forwards for both AcquirePeriod's and FrameRate's DRVL and
    DRLH fields. Having the limit specified in terms of frame rate would
    however would require changing the configuration parameter defined in
    the template st.cmd.
    
    To keep backward compatibility, the frame rate is computed based on the
    value of the AcquirePeriod.DRVL instead. Changing it at runtime requires
    reprocessing FrameRateLimitFwd to forward to FrameRate.DRVH.
    henriquesimoes committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    9e044f7 View commit details
    Browse the repository at this point in the history