fix: Annotations showing up on incorrect images #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
plt-joey
force-pushed
the
fix/annotationsOnIncorrectImages
branch
from
eec641f
to
f267d7c
Compare
sedghi
reviewed
Oct 29, 2024
| const endsWith = referencedImageId?.endsWith(imageURI); | ||
| if (endsWith) { | ||
| return endsWith; | ||
| const referenceColonIndex = referencedImageId.indexOf(':'); |
There was a problem hiding this comment.
can you use this one packages/core/src/utilities/imageIdToURI.ts
There was a problem hiding this comment.
Sure can, updated this check as well as the check above it (and fixed some redundancy there)
plt-joey
force-pushed
the
fix/annotationsOnIncorrectImages
branch
from
12e5cc8
to
c7c51fe
Compare
sedghi
reviewed
Oct 30, 2024
| if (endsWith) { | ||
| return endsWith; | ||
| imageURI = imageIdToURI(referencedImageId); | ||
| return true; |
There was a problem hiding this comment.
why return true here? I don't understand
There was a problem hiding this comment.
just removes a redundant check
before when it looked like:
if (!imageURI) {
imageURI = imageIdToURI(referencedImageId);
}
if (imageIdToURI(referencedImageId) === imageURI) {
return true;
}
if the first if (!imageURI) was true then the second would always be true, so simplifying it to
if (!imageURI) {
imageURI = imageIdToURI(referencedImageId);
return true;
} else if (imageIdToURI(referencedImageId) === imageURI) {
return true;
}
saves a call to imageIdToURI(referencedImageId) and an extra equivalency check
There was a problem hiding this comment.
can you do this instead
const { imageURI } = options;
// Direct URI match check
const currentImageURI = imageIdToURI(referencedImageId);
if (!imageURI || currentImageURI === imageURI) {
return true;
}
sedghi
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes issue described here: #1455
Changes & Results
Modified the image URI check in the
isReferenceViewablefunction inStackViewportfrom anendsWithmatch to an exact match. This stops annotations on images with IDs likedicom:126(which is the format used by the wadoURI filemanager) from displaying on the imagesdicom:26anddicom:6as well.Testing
The repro provided in the linked issue demonstrates the bug, replacing the UMD build of
@cornerstonejs/corewith one containing this change will fix the bug.Checklist
PR
semantic-release format and guidelines.
Code
My code has been well-documented (function documentation, inline comments,
etc.)
I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment