Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Annotations showing up on incorrect images #1460

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Annotations showing up on incorrect images #1460

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e18551
Fixing annotations showing up on incorrect images
plt-joey Sep 10, 2024
c7c51fe
Simplified annotation visibility check
plt-joey Oct 30, 2024
b1c78ca
Simplify annotation visibility check further
plt-joey Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions packages/core/src/RenderingEngine/StackViewport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3042,18 +3042,12 @@ class StackViewport extends Viewport {
}
}

let { imageURI } = options;
const { imageURI } = options;

if (!imageURI) {
// Remove the dataLoader scheme since that can change
imageURI = imageIdToURI(currentImageId);
}

const referencedImageURI = imageIdToURI(referencedImageId);

const endsWith = referencedImageId?.endsWith(imageURI);
if (endsWith) {
return endsWith;
// Direct URI match check
const currentImageURI = imageIdToURI(referencedImageId);
if (!imageURI || currentImageURI === imageURI) {
return true;
}

// if camera focal point is provided, we can use that as a point
Expand Down
Loading