-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
comments should not change parser state #334
base: main
Are you sure you want to change the base?
comments should not change parser state #334
Conversation
The parser is generated. To change the parser you'll have to change the grammar. Lines 35 to 38 in 00fcc43
To regenerate the parsers you can follow these instructions: https://github.com/cucumber/gherkin/blob/main/CONTRIBUTING.md#generating-parsers |
I have changed the grammar to allow any mixture of empty lines, comments and other-lines as the description. Extracting only the other-lines from the Description-AST-Node (as before) should yield the description-text without the comments and empty lines. Only difference is now that a collection of ony empty-lines and comments would yield an empty description text instead of a non-existing Description node. |
Changed the grammar in a way that is more consistent with the former test cases (treating empty lines inside description blocks as '#Other' lines). |
π€ What's changed?
β‘οΈ What's your motivation?
π·οΈ What kind of change is this?
β»οΈ Anything particular you want feedback on?
π Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.