Delete web-angular-simple & console-simple templates #400
Conversation
Also delete web-polymer files that should've been gone long ago.
README.md
Outdated
| * Mobile first | ||
| * Support for both server and client apps | ||
| * The best way to create a new Dart project | ||
| * Used by WebStorm, Atom, Sublime, and more |
There was a problem hiding this comment.
IntelliJ, WebStorm, ...?
There was a problem hiding this comment.
Good point. Done.
|
lgtm re: the removal and cleanup |
CHANGELOG.md
Outdated
| @@ -1,3 +1,11 @@ | |||
| ## Unreleased | |||
|
|
|||
| - Per issue #390, removed the `web-angular-simple` and `web-stagexl` templates. | |||
There was a problem hiding this comment.
You'll want to put a full URL to the issue if you want it to be a link.
There was a problem hiding this comment.
Good point. I decided to explain it, rather than link to the bug.
There was a problem hiding this comment.
The new explanatory text works well.
CHANGELOG.md
Outdated
|
|
||
| - Per issue #390, removed the `web-angular-simple` and `web-stagexl` templates. | ||
| Documentation (such as the | ||
| [Angular guide](https://webdev.dartlang.org/angular/guide/setup) |
There was a problem hiding this comment.
I think that you intended to have a closing parentheses at the end of this line -- if not, well, a closing parentheses is missing.
README.md
Outdated
| * `web-angular-simple` - A minimalist example app used in docs. | ||
| * `web-simple` - An absolute bare-bones web app. | ||
| * `web-stagexl` - A basic 2D canvas app with StageXL. | ||
| * `web-angular` - A web app that uses the AngularDart framework. |
There was a problem hiding this comment.
Would we want to also mention that web-angular highlights use of AngularDart and Angular Components?
There was a problem hiding this comment.
I considered that but opted for the shorter description, since the extra words don't differentiate it from the other templates.
There was a problem hiding this comment.
How about
- An AngularDart web app with Angular Components
(We don't need the work "framework" IMHO.)
There was a problem hiding this comment.
I'm not sure "with Angular Components" adds anything for people who don't already know about AngularDart. If I referred to the components, I might say:
An AngularDart web app that uses material design components.
That's awfully long, though. In the WebStorm UI, it'd look something like this (hmm... just realized that the web app names aren't consistent):
Console Application - a larger command-line application sample.
Simple Console Application - a simple command-line application.
Dart Package - a starting point for Dart libraries or applications.
Shelf Web Server - a web server built using the shelf package.
AngularDart Web Application - an AngularDart web app that uses material design components.
Low-level HTML App - A bare-bones web app.
The nice thing about the previous description is web app is easier to see, and it's shorter (though still longer than every other description):
Console Application - a larger command-line application sample.
Simple Console Application - a simple command-line application.
Dart Package - a starting point for Dart libraries or applications.
Shelf Web Server - a web server built using the shelf package.
AngularDart Web Application - a web app that uses the AngularDart framework.
Low-level HTML App - a bare-bones web app.
Another possibility:
Console Application - a larger command-line application sample.
Simple Console Application - a simple command-line application.
Dart Package - a starting point for Dart libraries or applications.
Shelf Web Server - a web server built using the shelf package.
AngularDart Web App - a web app with material design components.
Low-level HTML App - a bare-bones web app.
There was a problem hiding this comment.
+1 to AngularDart Web App - a web app with material design components.
lib/generators/web_angular.dart
Outdated
| : super('web-angular', 'Angular Web Application', | ||
| 'A web app built using the latest stable version of Angular.', | ||
| : super('web-angular', 'AngularDart Web Application', | ||
| 'A web app that uses the AngularDart framework.', |
There was a problem hiding this comment.
Again here: would we want to also mention that web-angular highlights use of AngularDart and Angular Components?
There was a problem hiding this comment.
This text is used to auto-update the text in the README and index page. (Something I forget every time!)
site/index.html
Outdated
| <li>web-angular-simple - <em>A minimalist example app used in docs.</em></li> | ||
| <li>web-simple - <em>An absolute bare-bones web app.</em></li> | ||
| <li>web-stagexl - <em>A basic 2D canvas app with StageXL.</em></li> | ||
| <li>web-angular - <em>A web app that uses the AngularDart framework.</em></li> |
There was a problem hiding this comment.
Ditto, remark about possibly also mentioning Angular Components.
kwalrath
changed the title
|
I'm going to create a new PR for this. |
Also tweak the descriptions of the remaining web-* templates, do a minor edit of the README,
and remove leftover polymer files.
Contributes to fixing #390.
Fixes #387.