Delete web-angular-simple & console-simple templates #403

kwalrath · 2017-05-08T23:00:24Z

Also tweak template descriptions.

This contributes to #390. This PR replaces #400, which was LGTM'd but also removed the StageXL template.

devoncarew · 2017-05-09T13:28:13Z

README.md

@@ -58,10 +56,10 @@ And to list all of the project templates:
 ## Goals

 * Opinionated and prescriptive; minimal to no options
-* Mobile-first
+* Mobile first


Hmm, I know this is existing, but how are we mobile first? Perhaps remove?

How about "Mobile friendly"?

Stagehand is mobile friendly? If you mean that some of the templates are, then we should be clear on that — something like "Stagehand templates for the web are mobile first".

devoncarew · 2017-05-09T13:47:04Z

lib/generators/web_simple.dart

@@ -11,8 +11,8 @@ import 'web_simple_data.dart';
 */
 class WebSimpleGenerator extends DefaultGenerator {
  WebSimpleGenerator()
-      : super('web-simple', 'Simple Web Application',
-            'An absolute bare-bones web app.',
+      : super('web-simple', 'Low-level HTML App',


It's not really clear to me what the term Low-level means in the context of a web app; Simple Web App seems clearer.

Hmm, to me, Low-level HTML App is actually clearer than "Simple Web App". How about "Web App without any framework"? We want to set the expectations that this is different from the AngularDart template.

filiph

Approve with nits.

filiph · 2017-05-09T17:57:11Z

README.md

@@ -58,10 +56,10 @@ And to list all of the project templates:
 ## Goals

 * Opinionated and prescriptive; minimal to no options
-* Mobile-first
+* Mobile first


Stagehand is mobile friendly? If you mean that some of the templates are, then we should be clear on that — something like "Stagehand templates for the web are mobile first".

filiph · 2017-05-09T17:59:35Z

lib/generators/web_simple.dart

@@ -11,8 +11,8 @@ import 'web_simple_data.dart';
 */
 class WebSimpleGenerator extends DefaultGenerator {
  WebSimpleGenerator()
-      : super('web-simple', 'Simple Web Application',
-            'An absolute bare-bones web app.',
+      : super('web-simple', 'Low-level HTML App',


Hmm, to me, Low-level HTML App is actually clearer than "Simple Web App". How about "Web App without any framework"? We want to set the expectations that this is different from the AngularDart template.

filiph · 2017-05-09T18:01:47Z

site/index.html

-  <li>web-angular-simple - <em>A minimalist example app used in docs.</em></li>
-  <li>web-simple - <em>An absolute bare-bones web app.</em></li>
+  <li>web-angular - <em>A web app with material design components.</em></li>
+  <li>web-simple - <em>A bare-bones web app.</em></li>


A bare-bones web app without use of any framework? A framework-less web app?

How about:

Available generators: console-full - A command-line application sample. package-simple - A starting point for Dart libraries or applications. server-shelf - A web server built using the shelf package. web-angular - A web app with material design components. web-simple - A web app that uses no framework. web-stagexl - A starting point for 2D animation and games.

And the (more important) IDE equivalents:

Console Application - a command-line application sample.
Dart Package - a starting point for Dart libraries or applications.
Shelf Web Server - a web server built using the shelf package.
AngularDart Web App - a web app with material design components.
Bare-bones Web App - a web app that uses no framework.
Simple StageXL Application - a starting point for 2D animation and games.

Hmmm... the last one could be:

StageXL Web App - ...

cc @Tomucha

One might argue that web-simple isn't really what we'd want to call a "web app". Anyhow ...

Rather than saying what it doesn't use, why not say what it does use? E.g. "A web app using only core Dart libraries"

Sorry, didn't see this until now. @filiph, what do you think?

kwalrath · 2017-05-09T19:48:31Z

@devoncarew & @filiph take another look, if you dare... If not, I'll merge this soon.

kwalrath · 2017-05-09T20:05:13Z

With my latest (last?) push, here are the descriptions:

Console Application - a command-line application sample.
Dart Package - a starting point for Dart libraries or applications.
Shelf Web Server - a web server built using the shelf package.
AngularDart Web App - a web app with material design components.
Bare-bones Web App - a web app that uses only core Dart libraries.
StageXL Web App - a starting point for 2D animation and games.

Available generators:
  console-full   - A command-line application sample.
  package-simple - A starting point for Dart libraries or applications.
  server-shelf   - A web server built using the shelf package.
  web-angular    - A web app with material design components.
  web-simple     - A web app that uses only core Dart libraries.
  web-stagexl    - A starting point for 2D animation and games.

kwalrath added 5 commits May 8, 2017 15:32

Remove web-angular-simple template

e306d9e

Remove generator files for web-angular-simple

3228632

Remove console-simple template

4646c4b

Remove unused web_polymer* files

1850bf8

Update CHANGELOG, README, template descriptions

54acb04

kwalrath requested review from filiph and devoncarew May 8, 2017 23:00

devoncarew approved these changes May 9, 2017

View reviewed changes

devoncarew reviewed May 9, 2017

View reviewed changes

filiph approved these changes May 9, 2017

View reviewed changes

kwalrath added 2 commits May 9, 2017 11:34

text tweaks

45508bd

Tweak StageXL template name visible in IDEs

8d2430d

Tweak web-simple description.

786fe78

chalin approved these changes May 9, 2017

View reviewed changes

kwalrath merged commit 445555e into master May 9, 2017

kwalrath deleted the curation2 branch May 9, 2017 20:13

This was referenced May 9, 2017

Improve the StageXL template description #402

Closed

curate the set of available templates #390

Closed

chalin mentioned this pull request Aug 21, 2018

templates: add web-angular-simple template #575

Closed

kwalrath mentioned this pull request Feb 26, 2020

StageXL app generator. #381

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete web-angular-simple & console-simple templates #403

Delete web-angular-simple & console-simple templates #403

kwalrath commented May 8, 2017

devoncarew May 9, 2017

kwalrath May 9, 2017

filiph May 9, 2017

devoncarew May 9, 2017

kwalrath May 9, 2017

filiph May 9, 2017

filiph left a comment

filiph May 9, 2017

filiph May 9, 2017

filiph May 9, 2017

kwalrath May 9, 2017

kwalrath May 9, 2017

kwalrath May 9, 2017

kwalrath May 9, 2017

chalin May 9, 2017

kwalrath May 9, 2017

kwalrath commented May 9, 2017

kwalrath commented May 9, 2017

Delete web-angular-simple & console-simple templates #403

Delete web-angular-simple & console-simple templates #403

Conversation

kwalrath commented May 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

filiph left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kwalrath commented May 9, 2017

kwalrath commented May 9, 2017