Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New naming scheme for theme roles + migrating some background colors. #8064

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Sep 19, 2024

  • Deployed to staging for further verification.
  • Started to separate named colors in an explicit way like smokeWhite and aliceBlue. These names are either from the HTML color names or if there is no such name, a widely used name is picked for it.
  • Merged very similar colors into a single one, e.g. f8f8f8 and f8f9fa is both merged into f5f5f7. Fewer colors makes a more consistent color palette, and the contrast/separation between them is easier to review.
  • Started to refactor and use names that first focus on their role neutral, inset, selected and then specify their property like bgColor or hover-bgColor. This makes it much easier to pick the appropriate variable when selecting colors for a component, e.g. selection or hovering should be consistent across the components this way.
  • The PR is mostly for some of the background colors, but wanted to verify the naming style before spending much time on it.

@sigurdm
Copy link
Contributor

sigurdm commented Sep 24, 2024

Can we keep the colder highlight color?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants