Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found 34 files excluded from sound null safety in webdev/ #1640

Closed
Tracked by #49169 ...
devoncarew opened this issue Jun 6, 2022 · 13 comments · Fixed by #1763
Closed
Tracked by #49169 ...

Found 34 files excluded from sound null safety in webdev/ #1640

devoncarew opened this issue Jun 6, 2022 · 13 comments · Fixed by #1763
Assignees

Comments

@devoncarew
Copy link
Member

Found 34 files excluded from sound null safety in webdev/:

webdev/bin/webdev.dart:5:// @dart = 2.9
webdev/lib/src/command/build_command.dart:5:// @dart = 2.9
webdev/lib/src/command/configuration.dart:5:// @dart = 2.9
webdev/lib/src/command/daemon_command.dart:5:// @dart = 2.9
webdev/lib/src/command/serve_command.dart:5:// @dart = 2.9
webdev/lib/src/command/shared.dart:5:// @dart = 2.9
webdev/lib/src/daemon/app_domain.dart:5:// @dart = 2.9
webdev/lib/src/daemon/daemon.dart:5:// @dart = 2.9
webdev/lib/src/daemon/daemon_domain.dart:5:// @dart = 2.9
webdev/lib/src/daemon/domain.dart:5:// @dart = 2.9
webdev/lib/src/daemon/utilites.dart:5:// @dart = 2.9
webdev/lib/src/daemon_client.dart:5:// @dart = 2.9
webdev/lib/src/logging.dart:5:// @dart = 2.9
webdev/lib/src/pubspec.dart:5:// @dart = 2.9
webdev/lib/src/serve/chrome.dart:5:// @dart = 2.9
webdev/lib/src/serve/dev_workflow.dart:5:// @dart = 2.9
webdev/lib/src/serve/handlers/favicon_handler.dart:5:// @dart = 2.9
webdev/lib/src/serve/server_manager.dart:5:// @dart = 2.9
webdev/lib/src/serve/utils.dart:5:// @dart = 2.9
webdev/lib/src/serve/webdev_server.dart:5:// @dart = 2.9
webdev/lib/src/util.dart:5:// @dart = 2.9
webdev/lib/src/webdev_command_runner.dart:5:// @dart = 2.9
webdev/test/build/min_sdk_test.dart:5:// @dart = 2.9
webdev/test/chrome_test.dart:5:// @dart = 2.9
webdev/test/configuration_test.dart:5:// @dart = 2.9
webdev/test/daemon/app_domain_test.dart:5:// @dart = 2.9
webdev/test/daemon/daemon_domain_test.dart:5:// @dart = 2.9
webdev/test/daemon/launch_app_test.dart:5:// @dart = 2.9
webdev/test/daemon/utils.dart:5:// @dart = 2.9
webdev/test/e2e_test.dart:5:// @dart = 2.9
webdev/test/integration_test.dart:5:// @dart = 2.9
webdev/test/readme_test.dart:5:// @dart = 2.9
webdev/test/test_utils.dart:5:// @dart = 2.9
webdev/test/utils_test.dart:5:// @dart = 2.9

See dart-lang/sdk#49169 for more context.

@annagrin
Copy link
Contributor

Duplicate of #1327

@annagrin annagrin marked this as a duplicate of #1327 Jul 15, 2022
@devoncarew
Copy link
Member Author

@annagrin - this issue is for webdev; it looks like #1327 just covers package:dwds. Is that issue also meant to track migrating webdev to null safety?

@annagrin
Copy link
Contributor

@devoncarew you are right, let's keep this one for webdev only

@mit-mit
Copy link
Member

mit-mit commented Sep 12, 2022

@annagrin will you also be migrating this one? if so, got an eta?

@annagrin
Copy link
Contributor

annagrin commented Oct 4, 2022

@elliette is the current owner of the task.

@mit-mit
Copy link
Member

mit-mit commented Oct 5, 2022

Got it. @elliette do you have an estimate?

@elliette
Copy link
Contributor

elliette commented Oct 5, 2022

This is on our Q4 OKRs - I expect it will be done by EOY / beginning of Q1 2023. Thanks!

@vsmenon
Copy link
Member

vsmenon commented Oct 18, 2022

@elliette - we'd like to get this done by EOY. Do you think that's still on track?

@elliette
Copy link
Contributor

Yes, it's on track! I finished migrating the non-test directories yesterday, so only the tests are left.

@vsmenon
Copy link
Member

vsmenon commented Oct 18, 2022

@khyati82 @itsjustkevin - for tracking

natebosch added a commit that referenced this issue Oct 19, 2022
Towards #1640

Migrate all test files that don't import an unmigrated `lib/` library.
natebosch added a commit that referenced this issue Oct 19, 2022
Towards #1640

Migrate all test files that don't import an unmigrated `lib/` library.
natebosch added a commit that referenced this issue Oct 19, 2022
Towards #1640

Migrate all test files that don't import an unmigrated `lib/` library.
natebosch added a commit that referenced this issue Oct 19, 2022
natebosch added a commit that referenced this issue Oct 20, 2022
natebosch added a commit that referenced this issue Oct 21, 2022
Closes #1640

Migrate the last unmigrated libraries from `lib/` as well as the binary.
@a-siva
Copy link

a-siva commented Oct 24, 2022

Are we going to do a release of the webdev package with the new null safe changes ?

@elliette
Copy link
Contributor

Yes, I will! Planning on doing that this week after some manual sanity-check testing

@elliette
Copy link
Contributor

elliette commented Nov 1, 2022

Just published the null-safe version 2.7.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants