Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate dwds to null safety #1327

Closed
Tracked by #49169
jmagman opened this issue May 25, 2021 · 8 comments
Closed
Tracked by #49169

Migrate dwds to null safety #1327

jmagman opened this issue May 25, 2021 · 8 comments
Assignees

Comments

@jmagman
Copy link

jmagman commented May 25, 2021

dwds 11.0.2 is not null safe:

// @dart = 2.9

This is preventing the flutter_tool from migrating to null safety.
https://github.com/flutter/flutter/blob/4a33813b3500308bb579a1dad5560971baec899f/packages/flutter_tools/lib/src/isolated/resident_web_runner.dart#L9

Note dds just published a null safe 2.0 dart-lang/sdk#45756.

@jmagman
Copy link
Author

jmagman commented May 25, 2021

\cc @jonahwilliams

@grouma
Copy link
Member

grouma commented Jun 1, 2021

What's the priority here?

@jonahwilliams
Copy link
Contributor

This is low priority but nice to have

@annagrin annagrin added the p5 label Aug 20, 2021
@annagrin annagrin self-assigned this Dec 14, 2021
@devoncarew
Copy link
Member

Is this issue complete (package:dwds is now null safe?)?

@devoncarew
Copy link
Member

ping @elliette - do you know the status here?

@elliette
Copy link
Contributor

All files have been migrated and DWDS is now null-safe, but the null-safe version has not yet been released (planning to do that this week)

@devoncarew
Copy link
Member

Thanks! Can you update this (and #1640) when that happens?

@elliette
Copy link
Contributor

elliette commented Sep 1, 2022

Just published null-safe DWDS (v.16.0.0), therefore closing as completed.

@elliette elliette closed this as completed Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants