Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make data types null safe #1615

Merged
merged 10 commits into from
May 18, 2022
Merged

Make data types null safe #1615

merged 10 commits into from
May 18, 2022

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented May 14, 2022 •
edited
Loading

@annagrin annagrin mentioned this pull request May 14, 2022
Closed
@annagrin annagrin requested review from elliette and nshahan May 14, 2022 01:02
nshahan
nshahan approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but left one high level question to consider about making fields nullable.

dwds/lib/data/devtools_request.dart Show resolved Hide resolved
@annagrin annagrin mentioned this pull request May 17, 2022
Open
@annagrin annagrin merged commit c78e7cc into dart-lang:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshahan nshahan nshahan approved these changes

@elliette elliette elliette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annagrin @nshahan @elliette