Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hot restart hang if injected client throws an error #1670

Merged
merged 4 commits into from
Jun 30, 2022
Merged

Fix hot restart hang if injected client throws an error #1670

merged 4 commits into from
Jun 30, 2022

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Jun 30, 2022 •
edited
Loading

Fix hot restart issues caught in tests after null safety changes:

  • Account for a possible null list of parent modules in moduleParentGraph
  • Catch and report errors from injected client during hot restart instead of waiting for the new isolate and hanging
  • Add optional stack trace to the ChromeDebugException

Towards: #1327 (uncovered by migration)

@annagrin annagrin mentioned this pull request Jun 30, 2022
Merged
@annagrin annagrin requested review from elliette and grouma June 30, 2022 17:42
@annagrin
Copy link
Contributor Author

Webdev expression evaluation tests are failing due to dart-lang/sdk#49373

@annagrin annagrin merged commit 9c44284 into dart-lang:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliette elliette elliette approved these changes

@grouma grouma Awaiting requested review from grouma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annagrin @elliette