Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change type of expected value #890

Merged
merged 1 commit into from
Aug 22, 2023
Merged

change type of expected value #890

merged 1 commit into from
Aug 22, 2023

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Aug 21, 2023

resolves #889
docs dbt-labs/docs.getdbt.com/#

Problem

currently believe that adding this integer check dbt-labs/dbt-core#8306 for agate changes availability of use of AnyFloat

Solution

swap to AnyInteger

Todo:

  • backport to 1.6.latest if approved and merged.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42 McKnight-42 self-assigned this Aug 21, 2023
@McKnight-42 McKnight-42 requested a review from a team as a code owner August 21, 2023 23:10
@McKnight-42 McKnight-42 requested a review from Fleid August 21, 2023 23:10
@cla-bot cla-bot bot added the cla:yes label Aug 21, 2023
@github-christophe-oudar
Copy link
Contributor

I was pretty sure it was a side effect from a dependency, thanks for figuring it out!

@McKnight-42
Copy link
Contributor Author

It's interesting if you check out the printed nodes mid-test run when it is still left as AnyFloat the shows three results one for each of the models and seed and the test fails. But once you swap it to AnyInteger it prints out four in total with the seed node having a extra node seemingly but test passes.

@McKnight-42 McKnight-42 merged commit f2525cc into main Aug 22, 2023
30 checks passed
@McKnight-42 McKnight-42 deleted the mcknight/ADAP-838 branch August 22, 2023 15:39
github-actions bot pushed a commit that referenced this pull request Aug 22, 2023
McKnight-42 added a commit that referenced this pull request Aug 22, 2023
(cherry picked from commit f2525cc)

Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-838] failing docs_generate tests in dbt-bigquery main and 1.6.latest branches
3 participants