Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fontawesome #4514

Merged
merged 11 commits into from
Nov 21, 2023
Merged

Remove fontawesome #4514

merged 11 commits into from
Nov 21, 2023

Conversation

JKarlavige
Copy link
Collaborator

@JKarlavige JKarlavige commented Nov 20, 2023 •
edited
Loading

What are you changing in this pull request and why?

Asana task

This removes Font Awesome as part of the effort to reduce our Font Awesome bandwidth usage. We didn't use Font Awesome much, and these sections have been updated to use SVGs instead.

Previews

Social icons in footer:
https://docs-getdbt-com-git-remove-fontawesome-dbt-labs.vercel.app/

Social icons for authors:
https://docs-getdbt-com-git-remove-fontawesome-dbt-labs.vercel.app/author/joel_labes
https://docs-getdbt-com-git-remove-fontawesome-dbt-labs.vercel.app/author/doug_guthrie
https://docs-getdbt-com-git-remove-fontawesome-dbt-labs.vercel.app/author/emily_riederer

Guide card icons (search icon, external link icons, fa icons on cards in bullets below):
https://docs-getdbt-com-git-remove-fontawesome-dbt-labs.vercel.app/guides

  • Quickstart for dbt Core using GitHub Codespace
  • Quickstart for dbt Core from a manual install

Individual guide prev/next arrows and mobile menu caret:
https://docs-getdbt-com-git-remove-fontawesome-dbt-labs.vercel.app/guides/adapter-creation?step=5

Available integrations (external link icon on cards:
https://docs-getdbt-com-git-remove-fontawesome-dbt-labs.vercel.app/docs/use-dbt-semantic-layer/avail-sl-integrations

@vercel Vercel
Copy link

vercel bot commented Nov 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 4:16pm

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address labels Nov 20, 2023
@github-actions github-actions bot added size: large This change will more than a week to address and might require more than one person and removed size: medium This change will take up to a week to address labels Nov 20, 2023
JKarlavige
JKarlavige commented Nov 20, 2023
View reviewed changes
website/docusaurus.config.js
@@ -262,8 +267,7 @@ var siteSettings = {
"https://cdn.jsdelivr.net/npm/clipboard@2.0.11/dist/clipboard.min.js",
"/js/headerLinkCopy.js",
"/js/gtm.js",
"/js/onetrust.js",
"https://kit.fontawesome.com/7110474d41.js",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing font awesome script

JKarlavige
JKarlavige commented Nov 20, 2023
View reviewed changes
website/snippets/_sl-partner-links.md Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update affects the external link icon on the cards on this page: https://docs-getdbt-com-git-remove-fontawesome-dbt-labs.vercel.app/docs/use-dbt-semantic-layer/avail-sl-integrations

JKarlavige
JKarlavige commented Nov 20, 2023
View reviewed changes
website/src/components/author/index.js
Comment on lines +70 to +72
<div className="social-icon">
{getSvgIcon(link?.icon)}
</div>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now uses svgs for author social links: https://docs-getdbt-com-git-remove-fontawesome-dbt-labs.vercel.app/author/emily_riederer

JKarlavige
JKarlavige commented Nov 20, 2023
View reviewed changes
website/src/components/quickstartGuideCard/index.js Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Affects right arrow next to Start on Guide cards: https://docs-getdbt-com-git-remove-fontawesome-dbt-labs.vercel.app/guides

JKarlavige
JKarlavige commented Nov 20, 2023
View reviewed changes
website/src/components/quickstartTOC/index.js Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Affects prev/next buttons on guide page: https://docs-getdbt-com-git-remove-fontawesome-dbt-labs.vercel.app/guides/codespace?step=1

JKarlavige
JKarlavige commented Nov 20, 2023
View reviewed changes
website/src/components/searchInput/index.js Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Affects search icon on guides page: https://docs-getdbt-com-git-remove-fontawesome-dbt-labs.vercel.app/guides

@JKarlavige JKarlavige marked this pull request as ready for review November 20, 2023 22:22
@JKarlavige JKarlavige requested a review from a team as a code owner November 20, 2023 22:22
@JKarlavige JKarlavige requested review from a team, breezyfasano and john-rock and removed request for a team November 20, 2023 22:22
breezyfasano
breezyfasano approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@breezyfasano breezyfasano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

john-rock
john-rock approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@john-rock john-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JKarlavige JKarlavige merged commit 893f011 into current Nov 21, 2023
7 checks passed
@JKarlavige JKarlavige deleted the remove-fontawesome branch November 21, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezyfasano breezyfasano breezyfasano approved these changes

@john-rock john-rock john-rock approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: large This change will more than a week to address and might require more than one person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JKarlavige @breezyfasano @john-rock