Remove fontawesome #4514
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. This update affects the external link icon on the cards on this page: https://docs-getdbt-com-git-remove-fontawesome-dbt-labs.vercel.app/docs/use-dbt-semantic-layer/avail-sl-integrations |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ import useDocusaurusContext from '@docusaurus/useDocusaurusContext'; | |
| import BlogLayout from '@theme/BlogLayout'; | ||
| import getAllPosts from '../../utils/get-all-posts'; | ||
| import imageCacheWrapper from '../../../functions/image-cache-wrapper'; | ||
| import getSvgIcon from '../../utils/get-svg-icon'; | ||
|
|
||
| function Author(props) { | ||
| const { authorData } = props | ||
|
|
@@ -28,49 +29,63 @@ function Author(props) { | |
| <BlogLayout title={name}> | ||
| <Head> | ||
| <meta property="og:type" content="profile" /> | ||
| <meta | ||
| property="og:title" | ||
| content={`${name} - ${ | ||
| blogData && blogData.blogTitle && blogData.blogTitle | ||
| }`} | ||
| /> | ||
| {description && ( | ||
| <meta property="og:description" content={`${description}`} /> | ||
| )} | ||
| </Head> | ||
|
|
||
| <main itemScope itemType="http://schema.org/Person"> | ||
| <section className="author-header row align-items-center"> | ||
| <div className="author-header-left"> | ||
| <img | ||
| src={imageCacheWrapper(image_url)} | ||
| alt={name} | ||
| itemProp="image" | ||
| /> | ||
| </div> | ||
| <div className="author-header-right"> | ||
| <h1 itemProp="name">{name}</h1> | ||
| <h4 className="author-title" itemProp="jobTitle"> | ||
| {job_title && job_title} {organization && `@ ${organization}`} | ||
| <div className="author-links"> | ||
| {links && links.length > 0 && ( | ||
| <> | ||
| <span>|</span> | ||
| {links.map((link, i) => ( | ||
| <a | ||
| href={link.url} | ||
| title={`${name} - Social`} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| key={i} | ||
| > | ||
| {/* <!--! Font Awesome Pro 6.4.2 by @fontawesome - https://fontawesome.com License - https://fontawesome.com/license (Commercial License) Copyright 2023 Fonticons, Inc. --> */} | ||
| {link?.icon ? ( | ||
| <div className="social-icon"> | ||
| {getSvgIcon(link?.icon)} | ||
| </div> | ||
|
Comment on lines
+70
to
+72
There was a problem hiding this comment. Now uses svgs for author social links: https://docs-getdbt-com-git-remove-fontawesome-dbt-labs.vercel.app/author/emily_riederer |
||
| ) : null} | ||
| </a> | ||
| ))} | ||
| </> | ||
| )} | ||
| </div> | ||
| </h4> | ||
| <p itemProp="description">{description ? description : ""}</p> | ||
| </div> | ||
| </section> | ||
| {authorPosts && authorPosts.length > 0 && ( | ||
| <AuthorPosts | ||
| posts={authorPosts} | ||
| siteImg={siteConfig.themeConfig && siteConfig.themeConfig.image} | ||
| /> | ||
| )} | ||
| </main> | ||
| </BlogLayout> | ||
| ); | ||
|
|
@@ -98,7 +113,5 @@ function AuthorPosts({posts}) { | |
| ) | ||
| } | ||
|
|
||
| export default Author; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import getSvgIcon from "../../utils/get-svg-icon" | ||
|
|
||
| function Icon({ name }) { | ||
| return getSvgIcon(name) | ||
| } | ||
|
|
||
| export default Icon |
|
There was a problem hiding this comment. Affects right arrow next to |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing font awesome script