-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fontawesome #4514
Remove fontawesome #4514
Changes from 8 commits
9468072
0f0991e
7b1f375
aa04540
681019e
f553c21
89cb5c9
a69e87c
d755552
4f7cbc2
a2cdffa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This update affects the external link icon on the cards on this page: https://docs-getdbt-com-git-remove-fontawesome-dbt-labs.vercel.app/docs/use-dbt-semantic-layer/avail-sl-integrations |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,7 @@ import useDocusaurusContext from '@docusaurus/useDocusaurusContext'; | |
import BlogLayout from '@theme/BlogLayout'; | ||
import getAllPosts from '../../utils/get-all-posts'; | ||
import imageCacheWrapper from '../../../functions/image-cache-wrapper'; | ||
import getSvgIcon from '../../utils/get-svg-icon'; | ||
|
||
function Author(props) { | ||
const { authorData } = props | ||
|
@@ -28,49 +29,63 @@ function Author(props) { | |
<BlogLayout title={name}> | ||
<Head> | ||
<meta property="og:type" content="profile" /> | ||
<meta property="og:title" content={`${name} - ${blogData && blogData.blogTitle && blogData.blogTitle}`} /> | ||
{description && | ||
<meta | ||
property="og:title" | ||
content={`${name} - ${ | ||
blogData && blogData.blogTitle && blogData.blogTitle | ||
}`} | ||
/> | ||
{description && ( | ||
<meta property="og:description" content={`${description}`} /> | ||
} | ||
)} | ||
</Head> | ||
|
||
<main | ||
itemScope | ||
itemType="http://schema.org/Person"> | ||
<main itemScope itemType="http://schema.org/Person"> | ||
<section className="author-header row align-items-center"> | ||
<div className="author-header-left"> | ||
<img src={imageCacheWrapper(image_url)} alt={name} itemProp="image" /> | ||
<img | ||
src={imageCacheWrapper(image_url)} | ||
alt={name} | ||
itemProp="image" | ||
/> | ||
</div> | ||
<div className="author-header-right"> | ||
<h1 itemProp="name">{name}</h1> | ||
<h4 className="author-title" itemProp="jobTitle"> | ||
{job_title && job_title} {organization && `@ ${organization}`} | ||
{job_title && job_title} {organization && `@ ${organization}`} | ||
<div className="author-links"> | ||
{links && links.length > 0 && ( | ||
<> | ||
<span>|</span> | ||
{links.map((link, i) => ( | ||
<a | ||
href={link.url} | ||
title={`${name} - Social`} | ||
target="_blank" | ||
rel="noopener noreferrer" | ||
key={i} | ||
> | ||
<i className={`fab ${link.icon}`}></i> | ||
</a> | ||
))} | ||
</> | ||
) | ||
} | ||
</div> | ||
{links && links.length > 0 && ( | ||
<> | ||
<span>|</span> | ||
{links.map((link, i) => ( | ||
<a | ||
href={link.url} | ||
title={`${name} - Social`} | ||
target="_blank" | ||
rel="noopener noreferrer" | ||
key={i} | ||
> | ||
{/* <!--! Font Awesome Pro 6.4.2 by @fontawesome - https://fontawesome.com License - https://fontawesome.com/license (Commercial License) Copyright 2023 Fonticons, Inc. --> */} | ||
{link?.icon ? ( | ||
<div className="social-icon"> | ||
{getSvgIcon(link?.icon)} | ||
</div> | ||
Comment on lines
+70
to
+72
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Now uses svgs for author social links: https://docs-getdbt-com-git-remove-fontawesome-dbt-labs.vercel.app/author/emily_riederer |
||
) : null} | ||
</a> | ||
))} | ||
</> | ||
)} | ||
</div> | ||
</h4> | ||
<p itemProp="description">{description ? description : ''}</p> | ||
<p itemProp="description">{description ? description : ""}</p> | ||
</div> | ||
</section> | ||
{authorPosts && authorPosts.length > 0 && | ||
<AuthorPosts posts={authorPosts} siteImg={siteConfig.themeConfig && siteConfig.themeConfig.image} /> | ||
} | ||
{authorPosts && authorPosts.length > 0 && ( | ||
<AuthorPosts | ||
posts={authorPosts} | ||
siteImg={siteConfig.themeConfig && siteConfig.themeConfig.image} | ||
/> | ||
)} | ||
</main> | ||
</BlogLayout> | ||
); | ||
|
@@ -98,7 +113,5 @@ function AuthorPosts({posts}) { | |
) | ||
} | ||
|
||
|
||
|
||
export default Author; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import getSvgIcon from "../../utils/get-svg-icon" | ||
|
||
function Icon({ name }) { | ||
return getSvgIcon(name) | ||
} | ||
|
||
export default Icon |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Affects right arrow next to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing font awesome script