-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add upgrade tests to circleCI #9970
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9970 +/- ##
==========================================
+ Coverage 54.47% 54.49% +0.02%
==========================================
Files 1267 1267
Lines 159437 159437
Branches 3637 3637
==========================================
+ Hits 86856 86890 +34
+ Misses 72448 72414 -34
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. |
caaa9d2
to
a7582c2
Compare
9ec99c4
to
eb52f17
Compare
ceedd2f
to
7b88215
Compare
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
1 similar comment
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
d05ca7b
to
ab97acc
Compare
@@ -4721,6 +4762,243 @@ workflows: | |||
requires: | |||
- package-and-push-system-dev-ee | |||
|
|||
test-e2e-upgrade: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure i understand the value in these tests. if i understand, each e2e run runs determined $OLD_VERSION, doesn't do anything on that version, stops it, upgrades to the $HEAD, and then runs a test suite. but i don't see much of a difference between that and just testing against $HEAD to begin with; the only difference between those systems would be that one took a brief pause at some DB migration number, but even then they all the same migrations in the same order with essentially the same data. if we created some data or an experiment on $OLD_VERSION then upgraded to $HEAD and made sure the data looked right or the experiment successfully unpaused, that would cover a lot more of our previously experienced upgrade bugs.
Ticket
CM-449
Description
Add a new suite of
test-e2e-release-upgrade
tests that:For this iteration, I chose to omit a subset of the "regular" e2e tests that use SLURM, aws, or gcp -- I can add these back in later, if desired.
Commentary
Please refer to https://hpe-aiatscale.atlassian.net/wiki/spaces/ENGINEERIN/pages/1716125737/Cookbook+Release+Party#4.-Upgrade-Tests for more context on how these tests are running.
Test Plan
Observe that CircleCI passes: https://app.circleci.com/pipelines/gh/determined-ai/determined?branch=carolinac%2Fupgrade-tests
Checklist
docs/release-notes/
See Release Note for details.