Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add upgrade tests to circleCI #9970
base: main
Are you sure you want to change the base?
feat: add upgrade tests to circleCI #9970
Changes from 69 commits
7495b03
97bb470
6be4f25
5685d65
2f46c61
8d23145
53ced7a
81a4861
b6898d8
dfbcaf5
7fd3312
b44fb33
5841479
90b55c2
e8929d1
61c73ea
2dc4b58
a304f9d
106c553
75d3ebf
4059e5b
b14e9cf
37ee4ea
4c9f46d
e85d98d
192e853
abc4db5
2cdf9e7
d28a813
e53a404
26493c1
86a26a4
50d1baf
8066956
1f6d6cd
f867d1d
955a400
5fe0ca3
41b3332
0a347e0
098b990
e1d5d87
50c5286
c07f38f
a18b476
df5d971
b02df5f
73b6201
1563c89
6c045c7
2d5ec78
7e4febb
6731079
2bb26db
4a0145c
7397f90
f53e051
ab97acc
4066136
daebed6
8a4cd70
730e081
582cf15
4def26c
956d8f5
3bc4c97
b5c56b9
7a20e7e
e6c6f46
a7e0038
06fd8db
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure i understand the value in these tests. if i understand, each e2e run runs determined $OLD_VERSION, doesn't do anything on that version, stops it, upgrades to the $HEAD, and then runs a test suite. but i don't see much of a difference between that and just testing against $HEAD to begin with; the only difference between those systems would be that one took a brief pause at some DB migration number, but even then they all the same migrations in the same order with essentially the same data. if we created some data or an experiment on $OLD_VERSION then upgraded to $HEAD and made sure the data looked right or the experiment successfully unpaused, that would cover a lot more of our previously experienced upgrade bugs.