-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] - Support 9.0 version - changes #288
base: main
Are you sure you want to change the base?
[dotnet] - Support 9.0 version - changes #288
Conversation
@@ -7,7 +7,7 @@ Develop C# and .NET Core based applications. Includes all needed SDKs, extension | |||
|
|||
| Options Id | Description | Type | Default Value | | |||
|-----|-----|-----|-----| | |||
| imageVariant | .NET version: | string | 8.0-bookworm | | |||
| imageVariant | .NET version: | string | 9.0-bookworm | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this PR is merged, https://github.com/devcontainers/action will run automatically ; which opens a PR that updates the README file based on devcontainer-feature.json
and NOTES.md
.
Hence, can we revert the changes to this file to avoid merge conflicts? Thanks!
"8.0-bookworm", | ||
"6.0-bookworm", | ||
"6.0-bullseye", | ||
"8.0-noble", | ||
"9.0-jammy", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't support jammy
, its noble
"8.0-jammy", | ||
"6.0-jammy", | ||
"6.0-focal" | ||
], | ||
"default": "8.0-bookworm" | ||
"default": "9.0-bookworm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the tests?
@@ -7,7 +7,7 @@ Develop C# and .NET Core based applications. Includes all needed SDKs, extension | |||
|
|||
| Options Id | Description | Type | Default Value | | |||
|-----|-----|-----|-----| | |||
| imageVariant | .NET version: | string | 8.0-bookworm | | |||
| imageVariant | .NET version: | string | 9.0-bookworm | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment
"8.0-bookworm", | ||
"6.0-bookworm", | ||
"6.0-bullseye", | ||
"8.0-noble", | ||
"9.0-jammy", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment
@@ -7,7 +7,7 @@ Develop C# and .NET based applications. Includes all needed SDKs, extensions, an | |||
|
|||
| Options Id | Description | Type | Default Value | | |||
|-----|-----|-----|-----| | |||
| imageVariant | .NET version: | string | 8.0-bookworm | | |||
| imageVariant | .NET version: | string | 9.0-bookworm | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment
"8.0-bookworm", | ||
"6.0-bookworm", | ||
"6.0-bullseye", | ||
"8.0-noble", | ||
"9.0-jammy", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment
Ref: #1184
Devcontainer Name
Description
Changelog*
Checklist