Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet] - Support 9.0 version - changes #288

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −9
Open

[dotnet] - Support 9.0 version - changes #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dotnet-mssql/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Develop C# and .NET Core based applications. Includes all needed SDKs, extension

| Options Id | Description | Type | Default Value |
|-----|-----|-----|-----|
| imageVariant | .NET version: | string | 8.0-bookworm |
| imageVariant | .NET version: | string | 9.0-bookworm |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this PR is merged, https://github.com/devcontainers/action will run automatically ; which opens a PR that updates the README file based on devcontainer-feature.json and NOTES.md.

Hence, can we revert the changes to this file to avoid merge conflicts? Thanks!


This template references an image that was [pre-built](https://containers.dev/implementors/reference/#prebuilding) to automatically include needed devcontainer.json metadata.

Expand Down
7 changes: 5 additions & 2 deletions src/dotnet-mssql/devcontainer-template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "dotnet-mssql",
"version": "3.3.2",
"version": "3.4.0",
"name": "C# (.NET) and MS SQL",
"description": "Develop C# and .NET Core based applications. Includes all needed SDKs, extensions, dependencies and an MS SQL container for parallel database development. Adds an additional MS SQL container to the C# (.NET Core) container definition and deploys any .dacpac files from the mssql .devcontainer folder.",
"documentationURL": "https://github.com/devcontainers/templates/tree/main/src/dotnet-mssql",
Expand All @@ -11,17 +11,20 @@
"type": "string",
"description": ".NET version:",
"proposals": [
"9.0",
"8.0",
"6.0",
"9.0-bookworm",
"8.0-bookworm",
"6.0-bookworm",
"6.0-bullseye",
"8.0-noble",
"9.0-jammy",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't support jammy, its noble

"8.0-jammy",
"6.0-jammy",
"6.0-focal"
],
"default": "8.0-bookworm"
"default": "9.0-bookworm"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the tests?

}
},
"platforms": [
Expand Down
2 changes: 1 addition & 1 deletion src/dotnet-postgres/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Develop C# and .NET Core based applications. Includes all needed SDKs, extension

| Options Id | Description | Type | Default Value |
|-----|-----|-----|-----|
| imageVariant | .NET version: | string | 8.0-bookworm |
| imageVariant | .NET version: | string | 9.0-bookworm |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment


This template references an image that was [pre-built](https://containers.dev/implementors/reference/#prebuilding) to automatically include needed devcontainer.json metadata.

Expand Down
7 changes: 5 additions & 2 deletions src/dotnet-postgres/devcontainer-template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "dotnet-postgres",
"version": "3.2.2",
"version": "3.3.0",
"name": "C# (.NET) and PostgreSQL",
"description": "Develop C# and .NET Core based applications. Includes all needed SDKs, extensions, dependencies and a PostgreSQL container for parallel database development. Adds an additional PostgreSQL container to the C# (.NET Core) container definition.",
"documentationURL": "https://github.com/devcontainers/templates/tree/main/src/dotnet-postgres",
Expand All @@ -11,17 +11,20 @@
"type": "string",
"description": ".NET version:",
"proposals": [
"9.0",
"8.0",
"6.0",
"9.0-bookworm",
"8.0-bookworm",
"6.0-bookworm",
"6.0-bullseye",
"8.0-noble",
"9.0-jammy",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment

"8.0-jammy",
"6.0-jammy",
"6.0-focal"
],
"default": "8.0-bookworm"
"default": "9.0-bookworm"
}
},
"platforms": [
Expand Down
2 changes: 1 addition & 1 deletion src/dotnet/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Develop C# and .NET based applications. Includes all needed SDKs, extensions, an

| Options Id | Description | Type | Default Value |
|-----|-----|-----|-----|
| imageVariant | .NET version: | string | 8.0-bookworm |
| imageVariant | .NET version: | string | 9.0-bookworm |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment


This template references an image that was [pre-built](https://containers.dev/implementors/reference/#prebuilding) to automatically include needed devcontainer.json metadata.

Expand Down
7 changes: 5 additions & 2 deletions src/dotnet/devcontainer-template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "dotnet",
"version": "3.2.2",
"version": "3.3.0",
"name": "C# (.NET)",
"description": "Develop C# and .NET based applications. Includes all needed SDKs, extensions, and dependencies.",
"documentationURL": "https://github.com/devcontainers/templates/tree/main/src/dotnet",
Expand All @@ -11,17 +11,20 @@
"type": "string",
"description": ".NET version:",
"proposals": [
"9.0",
"8.0",
"6.0",
"9.0-bookworm",
"8.0-bookworm",
"6.0-bookworm",
"6.0-bullseye",
"8.0-noble",
"9.0-jammy",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment

"8.0-jammy",
"6.0-jammy",
"6.0-focal"
],
"default": "8.0-bookworm"
"default": "9.0-bookworm"
}
},
"platforms": [
Expand Down
Loading