Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert "fix: select-field not showing in correct place" #1614

Merged
merged 1 commit into from
Oct 1, 2024
Merged

fix: revert "fix: select-field not showing in correct place" #1614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/select/src/select/menu-wrapper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const MenuWrapper = ({
selectRef,
}) => {
return (
<Layer onBackdropClick={onClick} transparent disablePortal>
<Layer onBackdropClick={onClick} transparent>
<Popper
reference={selectRef}
placement="bottom-start"
Expand Down
7 changes: 0 additions & 7 deletions components/select/src/single-select-field/features/can_show_conditionally.feature
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions components/select/src/single-select-field/features/can_show_conditionally/index.js
View file
Open in desktop

This file was deleted.

39 changes: 0 additions & 39 deletions components/select/src/single-select-field/single-select-field.e2e.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,42 +43,3 @@ export const WithFilterable = () => (
)
export const WithLoading = () => <SingleSelectField loading />
export const WithoutOptions = () => <SingleSelectField />

export const WithHiddenParent = () => {
return (
<>
<div className="container">
<div className="hoverSpan">
<span>Hover over me</span>
<div className="hiddenSelect">
<SingleSelectField
dataTest="hoverable-select-field"
label="Choose something"
onChange={() => {}}
>
<SingleSelectOption value="1" label="one" />
<SingleSelectOption value="2" label="two" />
</SingleSelectField>
</div>
</div>
</div>
<style jsx>{`
.container {
width: 100%;
height: 100%;
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
font-size: 1rem;
}
.hiddenSelect {
display: none;
}
.hoverSpan:hover .hiddenSelect {
display: block;
}
`}</style>
</>
)
}
Loading