Set .exe extension and archive windows artifacts #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
thaJeztah
force-pushed
the
carry_archive_windows_artifacts
branch
from
e9fed89
to
058d54c
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Apr 23, 2020
| @@ -58,7 +58,8 @@ def packageBuildSteps = [ | |||
| stage("windows") { | |||
| try { | |||
| checkout scm | |||
| sh("make -f Makefile.win archive") | |||
| sh("make -f Makefile.win REF=v1.2.13 archive") | |||
There was a problem hiding this comment.
temporarily switched to build v1.2.13, to see if it also works on that version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at the upstream Makefile and perhaps this works, so pushing this to try in CI
This includes the changes from #139