Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set .exe extension and archive windows artifacts #176

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Set .exe extension and archive windows artifacts #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49674cf
Makefile.win: set BINARY_SUFFIX
thaJeztah Apr 23, 2020
058d54c
Archive windows artifacts
StefanScherer Mar 4, 2020
e79c19c
WIP try building v1.2.13
thaJeztah Apr 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ def packageBuildSteps = [
stage("windows") {
try {
checkout scm
sh("make -f Makefile.win archive")
sh("make -f Makefile.win REF=v1.2.13 archive")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temporarily switched to build v1.2.13, to see if it also works on that version

archiveArtifacts(artifacts: 'build/windows/containerd.zip', onlyIfSuccessful: true)
} finally {
deleteDir()
}
Expand Down
4 changes: 2 additions & 2 deletions Makefile.win
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,15 @@ windows-image:
.
echo 1 > $@

build/windows/%.exe: windows-image checkout
build/windows/%: windows-image checkout
Powershell.exe New-Item -ItemType Directory -Force -Path build/windows/
docker run \
--rm \
-v "$(CURDIR)/src/:C:/gopath/src" \
-v "$(CURDIR)/build/windows:C:/gopath/src/github.com/containerd/containerd/bin" \
-w "C:/gopath/src/github.com/containerd/containerd" \
dockereng/containerd-windows-builder \
make bin/$*
make BINARY_SUFFIX=".exe" bin/$*

build/windows/containerd.zip: build/windows/containerd.exe build/windows/ctr.exe
Powershell.exe Compress-Archive -Force -Path 'build/windows/*.exe' -DestinationPath '$@'
Expand Down