Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the sql OperationalError bug #210

Merged
merged 13 commits into from
Nov 25, 2024
Merged

Fix the sql OperationalError bug #210

merged 13 commits into from
Nov 25, 2024

Conversation

7hebel
Copy link
Contributor

@7hebel 7hebel commented Nov 24, 2024

Fix the sql OperationalError ocurring due to the invalid DATABASE_CONN_STRING protocol's / amount

@kraanzu kraanzu changed the base branch from main to develop November 25, 2024 04:39
@kraanzu kraanzu self-requested a review November 25, 2024 09:31
@@ -3,6 +3,6 @@

ROOT_FOLDER = Path(user_data_dir("dooit"))
DATABASE_FILE = ROOT_FOLDER / "dooit.db"
DATABASE_CONN_STRING = f"sqlite:////{DATABASE_FILE}"
DATABASE_CONN_STRING = f"sqlite:///{DATABASE_FILE}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm..it does work normally without the extra / but what about the OperationalError? How do I reproduce it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was specific to windows. Nice catch!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it seems to be windows-specific.

@kraanzu kraanzu merged commit 0e623cf into dooit-org:develop Nov 25, 2024
4 of 5 checks passed
@kraanzu kraanzu mentioned this pull request Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants