Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the sql OperationalError bug #210

Merged
merged 13 commits into from
Nov 25, 2024
Merged

Fix the sql OperationalError bug #210

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9c598bf
Merge pull request #208 from dooit-org/develop
kraanzu Nov 18, 2024
04d4cd4
docs: add basics skeleton
kraanzu Nov 24, 2024
695c042
docs: add basics docs
kraanzu Nov 24, 2024
20b7552
feat: add `get_formatter_by_id` for formatter store
kraanzu Nov 24, 2024
967ebd6
feat: unique IDs for todos and workspaces
kraanzu Nov 24, 2024
30c192c
cleanup: remove comment
kraanzu Nov 24, 2024
eedd3b3
update CHANGELOG
kraanzu Nov 24, 2024
0ba191b
revert back to autoinc ids
kraanzu Nov 24, 2024
2d0b3b5
update CHANGELOG
kraanzu Nov 24, 2024
c7166f6
update CHANGELOG
kraanzu Nov 24, 2024
7e9c173
Merge branch 'develop'
kraanzu Nov 24, 2024
3ab2375
Merge branch 'develop'
kraanzu Nov 24, 2024
cba28cf
Update _vars.py
7hebel Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dooit/api/_vars.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@

ROOT_FOLDER = Path(user_data_dir("dooit"))
DATABASE_FILE = ROOT_FOLDER / "dooit.db"
DATABASE_CONN_STRING = f"sqlite:////{DATABASE_FILE}"
DATABASE_CONN_STRING = f"sqlite:///{DATABASE_FILE}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm..it does work normally without the extra / but what about the OperationalError? How do I reproduce it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was specific to windows. Nice catch!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it seems to be windows-specific.


DATABASE_FILE.parent.mkdir(parents=True, exist_ok=True)
Loading