179 initialize user mode #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…os64 into 179_initialize_user_mode
| loglinef(Verbose, "(%s) Initializing tss", __FUNCTION__); | ||
|
|
||
| // These fields are reserved and must be set to 0 | ||
| kernel_tss.reserved0 = 0x00; |
There was a problem hiding this comment.
I like that this is all explicit, but it'd be more efficient to use memset() to zero the whole tss and then set the fields you want afterwards.
There was a problem hiding this comment.
yeah, i totally agree, but i haven't implemented memset yet XD
src/kernel/arch/x86_64/cpu/tss.c
Outdated
| // LIMIT 16:19 0 DPL: 0 P: 1 G:0 | ||
| gdt64[TSS_ENTRY_LOW] = 0x00; | ||
| gdt64[TSS_ENTRY_HIGH] = 0x00; | ||
| gdt64[TSS_ENTRY_LOW] = ((((uint64_t) &kernel_tss>>24) & 0xFF)<<56) /*bits 56:63*/ | ((uint64_t) (0 & 0xFF) << 48) /* bits 48:55 */ | ((uint64_t)0x89 << 40) /* bits 40:47*/| ((((uint64_t) &kernel_tss) & 0xFFFFFF) << 16) /* bits 15:39 */ | (uint64_t) 0x70 /* Base */; |
There was a problem hiding this comment.
this looks like lisp! hahaha
It might be easier to understand if you break this down into a few smaller steps (i.e. local variables) and then assemble those.
There was a problem hiding this comment.
ok, but then shouldn't be better to create a struct with bitfields?
If i start to create local variable is more or less the same aestethically.
Am i wrong?
Btw yeah probably at least using variables, shoul make it more readable!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.