-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comment provider #1095
Add comment provider #1095
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lotes could you describe the main use cases for this, besides the documentation provider?
@spoenemann There are two relevant design changes in here:
|
We can live with that, since filtering it out might be potentially destructive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, makes sense.
43dcd86
to
df3856a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks 👍
One minor comment, see below.
Co-authored-by: Mark Sujew <mark.sujew@typefox.io>
* Implement a CommentProvider * Fix tests * Add documentation and replace comment consuming in documentation provider * Make comment retrieval pretty Co-authored-by: Mark Sujew <mark.sujew@typefox.io> --------- Co-authored-by: Mark Sujew <mark.sujew@typefox.io>
serializes to
$comment
propertycomes with default multiline comments
replaces consumption of comments in documentation provider by a comment provider call
one thing that bothers me is that comments can get duplicated (I guess)
For file:
$comment(A) == $comment(B) == '/** comment */'