Remove undefined from joinTracedToNode signature #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it calls the function returned by `traceToNode`, which always returns `CompositeGeneratorNode`, it can never return `undefined`
msujew
reviewed
Oct 14, 2024
| @@ -167,7 +167,7 @@ export function joinTracedToNode<T extends AstNode>(astNode: T, property?: Prope | |||
| * arguments as expected by {@link joinToNode}, i.e. an `iterable`, a function `toGenerated` | |||
| * converting each element into a `Generated`, as well as some `options`. | |||
| * | |||
| * That function than joins the elements of `iterable` by delegating to {@link joinToNode}. | |||
| * That function then joins the elements of `iterable` by delegating to {@link joinToNode}. | |||
There was a problem hiding this comment.
Suggestion: The signature before this change also needs to be adjusted.
There was a problem hiding this comment.
Right, seems I forgot it earlier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it calls the function returned by
traceToNode, which always returnsCompositeGeneratorNode, it can never returnundefined