Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove undefined from joinTracedToNode signature #1711

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Remove undefined from joinTracedToNode signature #1711

merged 3 commits into from
Oct 14, 2024

Commits on Oct 9, 2024

  1. Fix typo in JSDoc

    @aabounegm
    aabounegm committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    8d52f4d View commit details
    Browse the repository at this point in the history

  2. Remove undefined from joinTracedToNode signature 

    Since it calls the function returned by `traceToNode`, which
always returns `CompositeGeneratorNode`, it can never return `undefined`
    @aabounegm
    aabounegm committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    ffb6075 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Remove forgotten undefined in overload

    @aabounegm
    aabounegm committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    0d68c87 View commit details
    Browse the repository at this point in the history