Sustainable Kibana Architecture: Move modules owned by `@elastic/obs-ux-infra_services-team` #202830

gsoldevila · 2024-12-03T22:12:27Z

Summary

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.

Important

We kindly ask you to:
- Manually fix the errors in the error section below (if there are any).
- Search for the packages[\/\\] and plugins[\/\\] patterns in the source code (Babel and Eslint config files), and update them appropriately.
- Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names
- Review all of the updated files, specially the .ts and .js files listed in the sections below, as some of them contain relative paths that have been updated.
- Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.:
  - customised eslint rules
  - docs pointing to source code

Note

This PR has been auto-generated.
Any manual contributions will be lost if the 'relocate' script is re-run.
Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash.
Please use #sustainable_kibana_architecture Slack channel for feedback.

Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe here.

6 plugin(s) are going to be relocated:

Id	Target folder
`@kbn/apm-data-access-plugin`	`x-pack/solutions/observability/plugins/apm_data_access`
`@kbn/apm-plugin`	`x-pack/solutions/observability/plugins/apm`
`@kbn/inventory-plugin`	`x-pack/solutions/observability/plugins/inventory`
`@kbn/metrics-data-access-plugin`	`x-pack/solutions/observability/plugins/metrics_data_access`
`@kbn/profiling-data-access-plugin`	`x-pack/solutions/observability/plugins/profiling_data_access`
`@kbn/profiling-plugin`	`x-pack/solutions/observability/plugins/profiling`

6 packages(s) are going to be relocated:

Id	Target folder
`@kbn/apm-data-view`	`src/platform/packages/shared/kbn-apm-data-view`
`@kbn/apm-types`	`x-pack/solutions/observability/packages/kbn-apm-types`
`@kbn/apm-utils`	`src/platform/packages/shared/kbn-apm-utils`
`@kbn/lens-embeddable-utils`	`src/platform/packages/shared/kbn-lens-embeddable-utils`
`@kbn/profiling-utils`	`src/platform/packages/shared/kbn-profiling-utils`
`@kbn/shared-svg`	`src/platform/packages/shared/kbn-shared-svg`

Updated references

./.buildkite/ftr_oblt_stateful_configs.yml
./.buildkite/scripts/steps/functional/apm_cypress.sh
./.buildkite/scripts/steps/functional/inventory_cypress.sh
./.buildkite/scripts/steps/functional/profiling_cypress.sh
./.eslintrc.js
./.github/paths-labeller.yml
./.gitignore
./docs/developer/plugin-list.asciidoc
./oas_docs/overlays/alerting.overlays.yaml
./oas_docs/scripts/merge_ess_oas.js
./oas_docs/scripts/merge_serverless_oas.js
./package.json
./packages/kbn-eslint-plugin-i18n/helpers/get_i18n_identifier_from_file_path.test.ts
./packages/kbn-eslint-plugin-telemetry/helpers/get_app_name.test.ts
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./src/dev/precommit_hook/casing_check_config.js
./src/dev/storybook/aliases.ts
./src/platform/packages/shared/kbn-lens-embeddable-utils/jest.config.js
./src/platform/packages/shared/kbn-profiling-utils/jest.config.js
./src/platform/packages/shared/kbn-shared-svg/jest.config.js
./tsconfig.base.json
./x-pack/.i18nrc.json
./x-pack/platform/packages/shared/ml/aiops_log_rate_analysis/queries/fetch_index_info.ts
./x-pack/platform/packages/shared/ml/aiops_log_rate_analysis/queries/fetch_significant_term_p_values.ts
./x-pack/platform/packages/shared/ml/aiops_log_rate_analysis/queries/fetch_top_terms.ts
./x-pack/platform/plugins/private/data_visualizer/public/application/index_data_visualizer/utils/saved_search_utils.ts
./x-pack/solutions/observability/plugins/apm/common/rules/apm_rule_types.ts
./x-pack/solutions/observability/plugins/apm/dev_docs/apm_queries.md
./x-pack/solutions/observability/plugins/apm/dev_docs/linting.md
./x-pack/solutions/observability/plugins/apm/dev_docs/local_setup.md
./x-pack/solutions/observability/plugins/apm/dev_docs/telemetry.md
./x-pack/solutions/observability/plugins/apm/dev_docs/testing.md
./x-pack/solutions/observability/plugins/apm/dev_docs/updating_functional_tests_archives.md
./x-pack/solutions/observability/plugins/apm/dev_docs/vscode_setup.md
./x-pack/solutions/observability/plugins/apm/ftr_e2e/README.md
./x-pack/solutions/observability/plugins/apm/jest.config.js
./x-pack/solutions/observability/plugins/apm/scripts/infer_route_return_types/index.ts
./x-pack/solutions/observability/plugins/apm/scripts/precommit.js
./x-pack/solutions/observability/plugins/apm/scripts/telemetry/main.ts
./x-pack/solutions/observability/plugins/apm_data_access/jest.config.js
./x-pack/solutions/observability/plugins/exploratory_view/common/annotations.ts
./x-pack/solutions/observability/plugins/inventory/README.md
./x-pack/solutions/observability/plugins/inventory/jest.config.js
./x-pack/solutions/observability/plugins/metrics_data_access/jest.config.js
./x-pack/solutions/observability/plugins/observability/common/annotations.ts
./x-pack/solutions/observability/plugins/profiling/README.md
./x-pack/solutions/observability/plugins/profiling/e2e/README.md
./x-pack/solutions/observability/plugins/profiling/jest.config.js
./x-pack/solutions/observability/plugins/profiling_data_access/jest.config.js
./x-pack/solutions/security/plugins/security_solution/server/utils/build_query/calculate_timeseries_interval.ts
./yarn.lock
.github/CODEOWNERS

Updated relative paths

src/platform/packages/shared/kbn-apm-data-view/tsconfig.json:2
src/platform/packages/shared/kbn-apm-utils/tsconfig.json:2
src/platform/packages/shared/kbn-lens-embeddable-utils/jest.config.js:12
src/platform/packages/shared/kbn-lens-embeddable-utils/tsconfig.json:2
src/platform/packages/shared/kbn-profiling-utils/jest.config.js:12
src/platform/packages/shared/kbn-profiling-utils/tsconfig.json:2
src/platform/packages/shared/kbn-shared-svg/jest.config.js:12
src/platform/packages/shared/kbn-shared-svg/tsconfig.json:2
x-pack/solutions/observability/packages/kbn-apm-types/tsconfig.json:2
x-pack/solutions/observability/plugins/apm/dev_docs/telemetry.md:17
x-pack/solutions/observability/plugins/apm/dev_docs/telemetry.md:22
x-pack/solutions/observability/plugins/apm/dev_docs/testing.md:130
x-pack/solutions/observability/plugins/apm/dev_docs/testing.md:222
x-pack/solutions/observability/plugins/apm/dev_docs/testing.md:78
x-pack/solutions/observability/plugins/apm/dev_docs/testing.md:96
x-pack/solutions/observability/plugins/apm/dev_docs/vscode_setup.md:42
x-pack/solutions/observability/plugins/apm/ftr_e2e/README.md:3
x-pack/solutions/observability/plugins/apm/ftr_e2e/tsconfig.json:2
x-pack/solutions/observability/plugins/apm/jest.config.js:12
x-pack/solutions/observability/plugins/apm/scripts/infer_route_return_types/index.ts:125
x-pack/solutions/observability/plugins/apm/scripts/precommit.js:15
x-pack/solutions/observability/plugins/apm/scripts/precommit.js:33
x-pack/solutions/observability/plugins/apm/scripts/precommit.js:38
x-pack/solutions/observability/plugins/apm/scripts/precommit.js:50
x-pack/solutions/observability/plugins/apm/scripts/shared/read_kibana_config.ts:16
x-pack/solutions/observability/plugins/apm/tsconfig.json:2
x-pack/solutions/observability/plugins/apm/tsconfig.json:7
x-pack/solutions/observability/plugins/apm_data_access/jest.config.js:12
x-pack/solutions/observability/plugins/apm_data_access/tsconfig.json:2
x-pack/solutions/observability/plugins/apm_data_access/tsconfig.json:6
x-pack/solutions/observability/plugins/inventory/e2e/tsconfig.json:2
x-pack/solutions/observability/plugins/inventory/jest.config.js:10
x-pack/solutions/observability/plugins/inventory/tsconfig.json:2
x-pack/solutions/observability/plugins/inventory/tsconfig.json:7
x-pack/solutions/observability/plugins/metrics_data_access/jest.config.js:10
x-pack/solutions/observability/plugins/metrics_data_access/tsconfig.json:2
x-pack/solutions/observability/plugins/metrics_data_access/tsconfig.json:6
x-pack/solutions/observability/plugins/profiling/README.md:52
x-pack/solutions/observability/plugins/profiling/e2e/README.md:3
x-pack/solutions/observability/plugins/profiling/e2e/tsconfig.json:11
x-pack/solutions/observability/plugins/profiling/e2e/tsconfig.json:2
x-pack/solutions/observability/plugins/profiling/jest.config.js:10
x-pack/solutions/observability/plugins/profiling/tsconfig.json:2
x-pack/solutions/observability/plugins/profiling_data_access/jest.config.js:12
x-pack/solutions/observability/plugins/profiling_data_access/tsconfig.json:2

github-actions · 2024-12-03T22:12:41Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

elasticmachine · 2024-12-04T08:32:44Z

Pinging @elastic/kibana-core (Team:Core)

elasticmachine · 2024-12-04T08:32:45Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

elasticmachine · 2024-12-04T08:54:54Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

github-actions · 2024-12-04T08:55:04Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

jasonrhodes

@gsoldevila I'm concerned because our team (@elastic/obs-ux-management-team) has been requested for review on this almost 8K file PR, but GitHub can't show all of those files.

So when I check the file filter to see which files belong to our team, I'm not sure if there are any?

I don't want to blindly approve this if GitHub is just not able to show us the files that belong to us (if they're included in the 5K files that can't be loaded)... suggestions?

afharo

Core changes LGTM

crespocarlos

I noticed that this folder x-pack/solutions/observability/plugins/Users/gsoldevila/Work/kibana-quaternary/* exists.

Is that correct?

crespocarlos

obs-ux-infra_services changes LGMT. it's mostly about moving files to the new structure. I run a quick test locally and everything looked fine.

jgowdyelastic

ML changes LGTM

gsoldevila · 2024-12-19T14:22:54Z

@gsoldevila I'm concerned because our team (@elastic/obs-ux-management-team) has been requested for review on this almost 8K file PR, but GitHub can't show all of those files.

As discussed over Slack, consider using Github desktop to review such big PRs.

…-fix'

elasticmachine · 2024-12-23T16:51:25Z

💔 Build Failed

Buildkite Build
Commit: 0b3bdde
Storybooks Preview
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-202830-0b3bdde1c7b2

Failed CI Steps

Test Failures

[job] [logs] Jest Tests #19 / Get App Name should get the responsible app name from a file path
[job] [logs] Jest Tests #19 / Get App Name should get the responsible app name from a file path
[job] [logs] FTR Configs #74 / Visualizations - Group 3 lens app - TSVB Open in Lens Table should convert aggregate by to split row dimension

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	5.6MB	5.6MB	+29.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`apm`	68	52	-16
`profiling`	18	17	-1
total			-17

Total ESLint disabled count

id	before	after	diff
`apm`	81	65	-16
`profiling`	21	20	-1
total			-17

History

gsoldevila marked this pull request as ready for review December 4, 2024 08:32

gsoldevila requested review from a team as code owners December 4, 2024 08:32

botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Dec 4, 2024

gsoldevila force-pushed the kbn-team-1309-move-kibana-obs-ux-infra_services-team branch from d144359 to 592847f Compare December 10, 2024 15:34

Ikuni17 approved these changes Dec 11, 2024

View reviewed changes

nickofthyme approved these changes Dec 11, 2024

View reviewed changes

jasonrhodes reviewed Dec 16, 2024

View reviewed changes

afharo approved these changes Dec 17, 2024

View reviewed changes

rudolf added the plugin groups Relocate all plugins and packages under their respective platform/solution groups label Dec 18, 2024

crespocarlos reviewed Dec 18, 2024

View reviewed changes

crespocarlos approved these changes Dec 18, 2024

View reviewed changes

jgowdyelastic approved these changes Dec 19, 2024

View reviewed changes

marshallmain approved these changes Dec 19, 2024

View reviewed changes

gsoldevila force-pushed the kbn-team-1309-move-kibana-obs-ux-infra_services-team branch from 00d6622 to 71d5463 Compare December 23, 2024 14:13

gsoldevila requested a review from a team as a code owner December 23, 2024 14:13

gsoldevila added 12 commits December 23, 2024 15:56

Relocating module @kbn/apm-data-access-plugin

d2cb8f9

Relocating module @kbn/apm-data-view

00fee69

Relocating module @kbn/apm-plugin

5a1acfc

Relocating module @kbn/apm-types

de09fbf

Relocating module @kbn/apm-utils

edf4ff0

Relocating module @kbn/inventory-plugin

279ad1e

Relocating module @kbn/lens-embeddable-utils

64ca516

Relocating module @kbn/metrics-data-access-plugin

d8cfd13

Relocating module @kbn/profiling-data-access-plugin

30c5993

Relocating module @kbn/profiling-plugin

a345b7f

Relocating module @kbn/profiling-utils

433f1d1

Relocating module @kbn/shared-svg

e76018b

gsoldevila force-pushed the kbn-team-1309-move-kibana-obs-ux-infra_services-team branch from 2ce4469 to e76018b Compare December 23, 2024 15:11

kibanamachine added 2 commits December 23, 2024 15:27

[CI] Auto-commit changed files from 'node scripts/telemetry_check'

b987fab

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

0b3bdde

…-fix'

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sustainable Kibana Architecture: Move modules owned by `@elastic/obs-ux-infra_services-team` #202830

Sustainable Kibana Architecture: Move modules owned by `@elastic/obs-ux-infra_services-team` #202830

gsoldevila commented Dec 3, 2024 •

edited

Loading

github-actions bot commented Dec 3, 2024

elasticmachine commented Dec 4, 2024

elasticmachine commented Dec 4, 2024

elasticmachine commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

jasonrhodes left a comment •

edited

Loading

afharo left a comment

crespocarlos left a comment

crespocarlos left a comment

jgowdyelastic left a comment

gsoldevila commented Dec 19, 2024

elasticmachine commented Dec 23, 2024 •

edited

Loading

ESLint disabled line counts

Total ESLint disabled count

Sustainable Kibana Architecture: Move modules owned by @elastic/obs-ux-infra_services-team #202830

Are you sure you want to change the base?

Sustainable Kibana Architecture: Move modules owned by @elastic/obs-ux-infra_services-team #202830

Conversation

gsoldevila commented Dec 3, 2024 • edited Loading

Summary

6 plugin(s) are going to be relocated:

6 packages(s) are going to be relocated:

github-actions bot commented Dec 3, 2024

elasticmachine commented Dec 4, 2024

elasticmachine commented Dec 4, 2024

elasticmachine commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

🤖 GitHub comments

jasonrhodes left a comment • edited Loading

Choose a reason for hiding this comment

afharo left a comment

Choose a reason for hiding this comment

crespocarlos left a comment

Choose a reason for hiding this comment

crespocarlos left a comment

Choose a reason for hiding this comment

jgowdyelastic left a comment

Choose a reason for hiding this comment

gsoldevila commented Dec 19, 2024

elasticmachine commented Dec 23, 2024 • edited Loading

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

Sustainable Kibana Architecture: Move modules owned by `@elastic/obs-ux-infra_services-team` #202830

Sustainable Kibana Architecture: Move modules owned by `@elastic/obs-ux-infra_services-team` #202830

gsoldevila commented Dec 3, 2024 •

edited

Loading

jasonrhodes left a comment •

edited

Loading

elasticmachine commented Dec 23, 2024 •

edited

Loading