Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sustainable Kibana Architecture: Move modules owned by @elastic/obs-ux-infra_services-team #202830

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
14 changes: 7 additions & 7 deletions .buildkite/ftr_oblt_stateful_configs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ disabled:
- x-pack/solutions/observability/plugins/observability_onboarding/e2e/ftr_config_open.ts
- x-pack/solutions/observability/plugins/observability_onboarding/e2e/ftr_config_runner.ts
- x-pack/solutions/observability/plugins/observability_onboarding/e2e/ftr_config.ts
- x-pack/plugins/observability_solution/apm/ftr_e2e/ftr_config_run.ts
- x-pack/plugins/observability_solution/apm/ftr_e2e/ftr_config.ts
- x-pack/plugins/observability_solution/inventory/e2e/ftr_config_run.ts
- x-pack/plugins/observability_solution/inventory/e2e/ftr_config.ts
- x-pack/plugins/observability_solution/profiling/e2e/ftr_config_open.ts
- x-pack/plugins/observability_solution/profiling/e2e/ftr_config_runner.ts
- x-pack/plugins/observability_solution/profiling/e2e/ftr_config.ts
- x-pack/solutions/observability/plugins/apm/ftr_e2e/ftr_config_run.ts
- x-pack/solutions/observability/plugins/apm/ftr_e2e/ftr_config.ts
- x-pack/solutions/observability/plugins/inventory/e2e/ftr_config_run.ts
- x-pack/solutions/observability/plugins/inventory/e2e/ftr_config.ts
- x-pack/solutions/observability/plugins/profiling/e2e/ftr_config_open.ts
- x-pack/solutions/observability/plugins/profiling/e2e/ftr_config_runner.ts
- x-pack/solutions/observability/plugins/profiling/e2e/ftr_config.ts

#FTR configs
- x-pack/solutions/observability/plugins/uptime/e2e/config.ts
Expand Down
6 changes: 3 additions & 3 deletions .buildkite/scripts/pipelines/pull_request/pipeline.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ const getPipeline = (filename: string, removeSteps = true) => {

if (
(await doAnyChangesMatch([
/^x-pack\/plugins\/observability_solution\/apm/,
/^x-pack\/solutions\/observability\/plugins\/apm/,
/^packages\/kbn-apm-synthtrace/,
])) ||
GITHUB_PR_LABELS.includes('ci:all-cypress-suites')
Expand All @@ -88,7 +88,7 @@ const getPipeline = (filename: string, removeSteps = true) => {

if (
(await doAnyChangesMatch([
/^x-pack\/plugins\/observability_solution\/inventory/,
/^x-pack\/solutions\/observability\/plugins\/inventory/,
/^packages\/kbn-apm-synthtrace/,
])) ||
GITHUB_PR_LABELS.includes('ci:all-cypress-suites')
Expand All @@ -109,7 +109,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
}

if (
(await doAnyChangesMatch([/^x-pack\/plugins\/observability_solution\/profiling/])) ||
(await doAnyChangesMatch([/^x-pack\/solutions\/observability\/plugins\/profiling/])) ||
GITHUB_PR_LABELS.includes('ci:all-cypress-suites')
) {
pipeline.push(getPipeline('.buildkite/pipelines/pull_request/profiling_cypress.yml'));
Expand Down
2 changes: 1 addition & 1 deletion .buildkite/scripts/steps/functional/apm_cypress.sh
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@ echo "--- APM Cypress Tests"

cd "$XPACK_DIR"

node plugins/observability_solution/apm/scripts/test/e2e.js \
node solutions/observability/plugins/apm/scripts/test/e2e.js \
--kibana-install-dir "$KIBANA_BUILD_LOCATION" \
$CYPRESS_ARGS
2 changes: 1 addition & 1 deletion .buildkite/scripts/steps/functional/inventory_cypress.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ echo "--- Observability Inventory Cypress Tests"

cd "$XPACK_DIR"

node plugins/observability_solution/inventory/scripts/test/e2e.js \
node solutions/observability/plugins/inventory/scripts/test/e2e.js \
--kibana-install-dir "$KIBANA_BUILD_LOCATION" \
2 changes: 1 addition & 1 deletion .buildkite/scripts/steps/functional/profiling_cypress.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ echo "--- Profiling Cypress Tests"

cd "$XPACK_DIR"

NODE_OPTIONS=--openssl-legacy-provider node plugins/observability_solution/profiling/scripts/test/e2e.js \
NODE_OPTIONS=--openssl-legacy-provider node solutions/observability/plugins/profiling/scripts/test/e2e.js \
--kibana-install-dir "$KIBANA_BUILD_LOCATION" \
8 changes: 4 additions & 4 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ module.exports = {
'**/*.test.js',
'x-pack/test/apm_api_integration/**/*.ts',
'x-pack/test/functional/apps/**/*.js',
'x-pack/plugins/observability_solution/apm/**/*.js',
'x-pack/solutions/observability/plugins/apm/**/*.js',
'test/*/config.ts',
'test/*/config_open.ts',
'test/*/*.config.ts',
Expand Down Expand Up @@ -913,7 +913,7 @@ module.exports = {
*/
{
files: [
'x-pack/plugins/observability_solution/apm/**/*.{js,mjs,ts,tsx}',
'x-pack/solutions/observability/plugins/apm/**/*.{js,mjs,ts,tsx}',
'x-pack/solutions/observability/plugins/observability/**/*.{js,mjs,ts,tsx}',
'x-pack/solutions/observability/plugins/exploratory_view/**/*.{js,mjs,ts,tsx}',
'x-pack/solutions/observability/plugins/ux/**/*.{js,mjs,ts,tsx}',
Expand All @@ -934,7 +934,7 @@ module.exports = {
},
{
files: [
'x-pack/plugins/observability_solution/apm/**/*.stories.*',
'x-pack/solutions/observability/plugins/apm/**/*.stories.*',
'x-pack/solutions/observability/plugins/observability/**/*.stories.*',
'x-pack/solutions/observability/plugins/exploratory_view/**/*.stories.*',
'x-pack/solutions/observability/plugins/slo/**/*.stories.*',
Expand Down Expand Up @@ -999,7 +999,7 @@ module.exports = {
},
{
// require explicit return types in route handlers for performance reasons
files: ['x-pack/plugins/observability_solution/apm/server/**/route.ts'],
files: ['x-pack/solutions/observability/plugins/apm/server/**/route.ts'],
rules: {
'@typescript-eslint/explicit-function-return-type': [
'error',
Expand Down
30 changes: 15 additions & 15 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -279,11 +279,8 @@ packages/kbn-ambient-storybook-types @elastic/kibana-operations
packages/kbn-ambient-ui-types @elastic/kibana-operations
packages/kbn-analytics @elastic/kibana-core
packages/kbn-apm-config-loader @elastic/kibana-core @vigneshshanmugam
packages/kbn-apm-data-view @elastic/obs-ux-infra_services-team
packages/kbn-apm-synthtrace @elastic/obs-ux-infra_services-team @elastic/obs-ux-logs-team
packages/kbn-apm-synthtrace-client @elastic/obs-ux-infra_services-team @elastic/obs-ux-logs-team
packages/kbn-apm-types @elastic/obs-ux-infra_services-team
packages/kbn-apm-utils @elastic/obs-ux-infra_services-team
packages/kbn-axe-config @elastic/kibana-qa
packages/kbn-babel-preset @elastic/kibana-operations
packages/kbn-babel-register @elastic/kibana-operations
Expand Down Expand Up @@ -371,7 +368,6 @@ packages/kbn-jest-serializers @elastic/kibana-operations
packages/kbn-journeys @elastic/kibana-operations @elastic/appex-qa
packages/kbn-json-ast @elastic/kibana-operations
packages/kbn-kibana-manifest-schema @elastic/kibana-operations
packages/kbn-lens-embeddable-utils @elastic/obs-ux-infra_services-team @elastic/kibana-visualizations
packages/kbn-lens-formula-docs @elastic/kibana-visualizations
packages/kbn-lint-packages-cli @elastic/kibana-operations
packages/kbn-lint-ts-projects-cli @elastic/kibana-operations
Expand Down Expand Up @@ -403,7 +399,6 @@ packages/kbn-picomatcher @elastic/kibana-operations
packages/kbn-plugin-check @elastic/appex-sharedux
packages/kbn-plugin-generator @elastic/kibana-operations
packages/kbn-plugin-helpers @elastic/kibana-operations
packages/kbn-profiling-utils @elastic/obs-ux-infra_services-team
packages/kbn-react-field @elastic/kibana-data-discovery
packages/kbn-react-mute-legacy-root-warning @elastic/appex-sharedux
packages/kbn-recently-accessed @elastic/appex-sharedux
Expand Down Expand Up @@ -448,7 +443,6 @@ packages/kbn-search-types @elastic/kibana-data-discovery
packages/kbn-security-hardening @elastic/kibana-security
packages/kbn-server-http-tools @elastic/kibana-core
packages/kbn-set-map @elastic/kibana-operations
packages/kbn-shared-svg @elastic/obs-ux-infra_services-team
packages/kbn-shared-ux-utility @elastic/appex-sharedux
packages/kbn-some-dev-log @elastic/kibana-operations
packages/kbn-sort-package-json @elastic/kibana-operations
Expand Down Expand Up @@ -571,6 +565,8 @@ src/platform/packages/shared/deeplinks/management @elastic/kibana-management
src/platform/packages/shared/deeplinks/ml @elastic/ml-ui
src/platform/packages/shared/deeplinks/observability @elastic/obs-ux-management-team
src/platform/packages/shared/deeplinks/security @elastic/security-solution
src/platform/packages/shared/kbn-apm-data-view @elastic/obs-ux-infra_services-team
src/platform/packages/shared/kbn-apm-utils @elastic/obs-ux-infra_services-team
src/platform/packages/shared/kbn-avc-banner @elastic/security-defend-workflows
src/platform/packages/shared/kbn-cell-actions @elastic/security-threat-hunting-explore
src/platform/packages/shared/kbn-custom-icons @elastic/obs-ux-logs-team
Expand All @@ -581,6 +577,7 @@ src/platform/packages/shared/kbn-esql-ast @elastic/kibana-esql
src/platform/packages/shared/kbn-esql-utils @elastic/kibana-esql
src/platform/packages/shared/kbn-esql-validation-autocomplete @elastic/kibana-esql
src/platform/packages/shared/kbn-io-ts-utils @elastic/obs-knowledge-team
src/platform/packages/shared/kbn-lens-embeddable-utils @elastic/obs-ux-infra_services-team @elastic/kibana-visualizations
src/platform/packages/shared/kbn-management/cards_navigation @elastic/kibana-management
src/platform/packages/shared/kbn-management/settings/components/field_input @elastic/kibana-management
src/platform/packages/shared/kbn-management/settings/components/field_row @elastic/kibana-management
Expand All @@ -589,6 +586,7 @@ src/platform/packages/shared/kbn-management/settings/types @elastic/kibana-manag
src/platform/packages/shared/kbn-management/settings/utilities @elastic/kibana-management
src/platform/packages/shared/kbn-openapi-common @elastic/security-detection-rule-management
src/platform/packages/shared/kbn-osquery-io-ts-types @elastic/security-asset-management
src/platform/packages/shared/kbn-profiling-utils @elastic/obs-ux-infra_services-team
src/platform/packages/shared/kbn-react-hooks @elastic/obs-ux-logs-team
src/platform/packages/shared/kbn-router-utils @elastic/obs-ux-logs-team
src/platform/packages/shared/kbn-rule-data-utils @elastic/security-detections-response @elastic/response-ops @elastic/obs-ux-management-team
Expand All @@ -600,6 +598,7 @@ src/platform/packages/shared/kbn-securitysolution-rules @elastic/security-detect
src/platform/packages/shared/kbn-server-route-repository @elastic/obs-knowledge-team
src/platform/packages/shared/kbn-server-route-repository-client @elastic/obs-knowledge-team
src/platform/packages/shared/kbn-server-route-repository-utils @elastic/obs-knowledge-team
src/platform/packages/shared/kbn-shared-svg @elastic/obs-ux-infra_services-team
src/platform/packages/shared/kbn-sse-utils @elastic/obs-knowledge-team
src/platform/packages/shared/kbn-sse-utils-client @elastic/obs-knowledge-team
src/platform/packages/shared/kbn-sse-utils-server @elastic/obs-knowledge-team
Expand Down Expand Up @@ -902,15 +901,7 @@ x-pack/plugins/maps @elastic/kibana-presentation
x-pack/plugins/monitoring @elastic/stack-monitoring
x-pack/plugins/monitoring_collection @elastic/stack-monitoring
x-pack/plugins/notifications @elastic/appex-sharedux
x-pack/plugins/observability_solution/apm @elastic/obs-ux-infra_services-team
x-pack/plugins/observability_solution/apm_data_access @elastic/obs-ux-infra_services-team
x-pack/plugins/observability_solution/apm/ftr_e2e @elastic/obs-ux-infra_services-team
x-pack/plugins/observability_solution/inventory @elastic/obs-ux-infra_services-team
x-pack/plugins/observability_solution/inventory/e2e @elastic/obs-ux-infra_services-team
x-pack/plugins/observability_solution/metrics_data_access @elastic/obs-ux-infra_services-team
x-pack/plugins/observability_solution/observability_shared @elastic/observability-ui
x-pack/plugins/observability_solution/profiling @elastic/obs-ux-infra_services-team
x-pack/plugins/observability_solution/profiling_data_access @elastic/obs-ux-infra_services-team
x-pack/plugins/reporting @elastic/appex-sharedux
x-pack/plugins/rule_registry @elastic/response-ops @elastic/obs-ux-management-team
x-pack/plugins/saved_objects_tagging @elastic/appex-sharedux
Expand All @@ -935,16 +926,23 @@ x-pack/plugins/upgrade_assistant @elastic/kibana-core
x-pack/solutions/observability/packages/alert_details @elastic/obs-ux-management-team
x-pack/solutions/observability/packages/alerting_test_data @elastic/obs-ux-management-team
x-pack/solutions/observability/packages/get_padded_alert_time_range_util @elastic/obs-ux-management-team
x-pack/solutions/observability/packages/kbn-apm-types @elastic/obs-ux-infra_services-team
x-pack/solutions/observability/packages/kbn-custom-integrations @elastic/obs-ux-logs-team
x-pack/solutions/observability/packages/kbn-investigation-shared @elastic/obs-ux-management-team
x-pack/solutions/observability/packages/observability_ai/observability_ai_common @elastic/obs-ai-assistant
x-pack/solutions/observability/packages/observability_ai/observability_ai_server @elastic/obs-ai-assistant
x-pack/solutions/observability/packages/synthetics_test_data @elastic/obs-ux-management-team
x-pack/solutions/observability/plugins/apm @elastic/obs-ux-infra_services-team
x-pack/solutions/observability/plugins/apm_data_access @elastic/obs-ux-infra_services-team
x-pack/solutions/observability/plugins/apm/ftr_e2e @elastic/obs-ux-infra_services-team
x-pack/solutions/observability/plugins/exploratory_view @elastic/obs-ux-management-team
x-pack/solutions/observability/plugins/infra @elastic/obs-ux-logs-team @elastic/obs-ux-infra_services-team
x-pack/solutions/observability/plugins/inventory @elastic/obs-ux-infra_services-team
x-pack/solutions/observability/plugins/inventory/e2e @elastic/obs-ux-infra_services-team
x-pack/solutions/observability/plugins/investigate @elastic/obs-ux-management-team
x-pack/solutions/observability/plugins/investigate_app @elastic/obs-ux-management-team
x-pack/solutions/observability/plugins/logs_explorer @elastic/obs-ux-logs-team
x-pack/solutions/observability/plugins/metrics_data_access @elastic/obs-ux-infra_services-team
x-pack/solutions/observability/plugins/observability @elastic/obs-ux-management-team
x-pack/solutions/observability/plugins/observability_ai_assistant_app @elastic/obs-ai-assistant
x-pack/solutions/observability/plugins/observability_ai_assistant_management @elastic/obs-ai-assistant
Expand All @@ -953,6 +951,8 @@ x-pack/solutions/observability/plugins/observability_onboarding @elastic/obs-ux-
x-pack/solutions/observability/plugins/observability_onboarding/e2e @elastic/obs-ux-logs-team
x-pack/solutions/observability/plugins/observability_solution/entities_data_access @elastic/obs-entities
x-pack/solutions/observability/plugins/observability_solution/entity_manager_app @elastic/obs-entities
x-pack/solutions/observability/plugins/profiling @elastic/obs-ux-infra_services-team
x-pack/solutions/observability/plugins/profiling_data_access @elastic/obs-ux-infra_services-team
x-pack/solutions/observability/plugins/serverless_observability @elastic/obs-ux-management-team
x-pack/solutions/observability/plugins/slo @elastic/obs-ux-management-team
x-pack/solutions/observability/plugins/streams @elastic/streams-program-team
Expand Down Expand Up @@ -3294,7 +3294,7 @@ x-pack/solutions/observability/packages/alert_details @elastic/obs-ux-management
x-pack/solutions/observability/packages/alerting_test_data @elastic/obs-ux-management-team
x-pack/solutions/observability/packages/get_padded_alert_time_range_util @elastic/obs-ux-management-team
x-pack/solutions/observability/packages/kbn-alerts-grouping @elastic/response-ops
x-pack/solutions/observability/packages/kbn-apm-types @elastic/obs-ux-infra_services-team
x-pack/solutions/observability/x-pack/solutions/observability/packages/kbn-apm-types @elastic/obs-ux-infra_services-team
x-pack/solutions/observability/x-pack/solutions/observability/packages/kbn-custom-integrations @elastic/obs-ux-logs-team
x-pack/solutions/observability/packages/kbn-investigation-shared @elastic/obs-ux-management-team
x-pack/solutions/observability/src/platform/packages/shared/kbn-timerange @elastic/obs-ux-logs-team
Expand Down
4 changes: 2 additions & 2 deletions .github/paths-labeller.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@
- 'src/plugins/expressions/**/*.*'
- 'src/plugins/bfetch/**/*.*'
- 'Team:obs-ux-infra_services':
- 'x-pack/plugins/observability_solution/apm/**/*.*'
- 'x-pack/solutions/observability/plugins/apm/**/*.*'
- 'x-pack/test/apm_api_integration/**/*.*'
- 'packages/kbn-apm-synthtrace/**/*.*'
- 'packages/kbn-apm-synthtrace-client/**/*.*'
- 'packages/kbn-apm-utils/**/*.*'
- 'src/platform/packages/shared/kbn-apm-utils/**/*.*'
- 'x-pack/solutions/observability/plugins/ux/**/*.*'
- 'Team:Fleet':
- 'x-pack/plugins/fleet/**/*.*'
Expand Down
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ npm-debug.log*
## @cypress/snapshot from apm plugin
/snapshots.js
/apm-diagnostics*.json
/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/service_map/snapshots/*.actual.png
/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/service_map/snapshots/*.diff.png
/x-pack/solutions/observability/plugins/apm/ftr_e2e/cypress/e2e/service_map/snapshots/*.actual.png
/x-pack/solutions/observability/plugins/apm/ftr_e2e/cypress/e2e/service_map/snapshots/*.diff.png

# transpiled cypress config
x-pack/plugins/fleet/cypress.config.d.ts
Expand Down
12 changes: 6 additions & 6 deletions docs/developer/plugin-list.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -459,11 +459,11 @@ The plugin exposes the static DefaultEditorController class to consume.
|The Kibana Alerting plugin provides a common place to set up rules. You can:


|{kib-repo}blob/{branch}/x-pack/plugins/observability_solution/apm/readme.md[apm]
|{kib-repo}blob/{branch}/x-pack/solutions/observability/plugins/apm/readme.md[apm]
|This plugin provides access to App Monitoring features provided by Elastic. It allows you to monitor your software services and applications in real-time; visualize detailed performance information on your services, identify and analyze errors, and monitor host-level and APM agent-specific metrics like JVM and Go runtime metrics.


|{kib-repo}blob/{branch}/x-pack/plugins/observability_solution/apm_data_access[apmDataAccess]
|{kib-repo}blob/{branch}/x-pack/solutions/observability/plugins/apm_data_access[apmDataAccess]
|WARNING: Missing README.


Expand Down Expand Up @@ -658,7 +658,7 @@ the infrastructure monitoring use-case within Kibana.
|Team owner: Security Integrations Scalability


|{kib-repo}blob/{branch}/x-pack/plugins/observability_solution/inventory/README.md[inventory]
|{kib-repo}blob/{branch}/x-pack/solutions/observability/plugins/inventory/README.md[inventory]
|Home of the Inventory plugin, which renders the... inventory.


Expand Down Expand Up @@ -719,7 +719,7 @@ using the CURL scripts in the scripts folder.
|Visualize geo data from Elasticsearch or 3rd party geo-services.


|{kib-repo}blob/{branch}/x-pack/plugins/observability_solution/metrics_data_access/README.md[metricsDataAccess]
|{kib-repo}blob/{branch}/x-pack/solutions/observability/plugins/metrics_data_access/README.md[metricsDataAccess]
|Exposes utilities to access metrics data.


Expand Down Expand Up @@ -780,11 +780,11 @@ Elastic.
|This plugin contains the product documentation base service.


|{kib-repo}blob/{branch}/x-pack/plugins/observability_solution/profiling/README.md[profiling]
|{kib-repo}blob/{branch}/x-pack/solutions/observability/plugins/profiling/README.md[profiling]
|Universal Profiling provides fleet-wide, whole-system, continuous profiling with zero instrumentation. Get a comprehensive understanding of what lines of code are consuming compute resources throughout your entire fleet by visualizing your data in Kibana using the flamegraph, stacktraces, and top functions views.


|{kib-repo}blob/{branch}/x-pack/plugins/observability_solution/profiling_data_access[profilingDataAccess]
|{kib-repo}blob/{branch}/x-pack/solutions/observability/plugins/profiling_data_access[profilingDataAccess]
|WARNING: Missing README.


Expand Down
Loading