-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Data frame analytics: Adds missing space between lines in delete job modal #204732
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Starting backport for target branches: 8.x |
… job modal (elastic#204732) Fix for: [elastic#204598](elastic#204598) After: <img width="995" alt="image" src="https://github.com/user-attachments/assets/4c5404af-aa0d-4860-beb9-0ada9312f125" /> (cherry picked from commit b50bec8)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…delete job modal (#204732) (#204967) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Data frame analytics: Adds missing space between lines in delete job modal (#204732)](#204732) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-12-19T15:35:37Z","message":"[ML] Data frame analytics: Adds missing space between lines in delete job modal (#204732)\n\nFix for: [#204598](https://github.com/elastic/kibana/issues/204598)\n\nAfter:\n\n<img width=\"995\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/4c5404af-aa0d-4860-beb9-0ada9312f125\"\n/>","sha":"b50bec8f2399e50a7647872897b327fe5139c052","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix",":ml","v9.0.0","Team:ML","backport:version","v8.18.0"],"title":"[ML] Data frame analytics: Adds missing space between lines in delete job modal","number":204732,"url":"https://github.com/elastic/kibana/pull/204732","mergeCommit":{"message":"[ML] Data frame analytics: Adds missing space between lines in delete job modal (#204732)\n\nFix for: [#204598](https://github.com/elastic/kibana/issues/204598)\n\nAfter:\n\n<img width=\"995\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/4c5404af-aa0d-4860-beb9-0ada9312f125\"\n/>","sha":"b50bec8f2399e50a7647872897b327fe5139c052"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204732","number":204732,"mergeCommit":{"message":"[ML] Data frame analytics: Adds missing space between lines in delete job modal (#204732)\n\nFix for: [#204598](https://github.com/elastic/kibana/issues/204598)\n\nAfter:\n\n<img width=\"995\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/4c5404af-aa0d-4860-beb9-0ada9312f125\"\n/>","sha":"b50bec8f2399e50a7647872897b327fe5139c052"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>
… job modal (elastic#204732) Fix for: [elastic#204598](elastic#204598) After: <img width="995" alt="image" src="https://github.com/user-attachments/assets/4c5404af-aa0d-4860-beb9-0ada9312f125" />
Fix for: #204598
After: