Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Data frame analytics: Adds missing space between lines in delete job modal #204732

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

rbrtj
Copy link
Contributor

@rbrtj rbrtj commented Dec 18, 2024

Fix for: #204598

After:

image

@rbrtj rbrtj added bug Fixes for quality problems that affect the customer experience release_note:fix :ml v9.0.0 Team:ML Team label for ML (also use :ml) backport:version Backport to applied version labels v8.18.0 labels Dec 18, 2024
@rbrtj rbrtj requested review from walterra and darnautov December 18, 2024 12:05
@rbrtj rbrtj self-assigned this Dec 18, 2024
@rbrtj rbrtj requested a review from a team as a code owner December 18, 2024 12:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.7MB 4.7MB +71.0B

cc @rbrtj

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 .

@peteharverson peteharverson changed the title [ML] DFA: Adds missing space between lines in delete DFA job modal [ML] Data frame analytics: Adds missing space between lines in delete job modal Dec 18, 2024
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbrtj rbrtj merged commit b50bec8 into elastic:main Dec 19, 2024
23 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12415857352

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 19, 2024
…delete job modal (#204732) (#204967)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Data frame analytics: Adds missing space between lines in delete
job modal (#204732)](#204732)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-12-19T15:35:37Z","message":"[ML]
Data frame analytics: Adds missing space between lines in delete job
modal (#204732)\n\nFix for:
[#204598](https://github.com/elastic/kibana/issues/204598)\n\nAfter:\n\n<img
width=\"995\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/4c5404af-aa0d-4860-beb9-0ada9312f125\"\n/>","sha":"b50bec8f2399e50a7647872897b327fe5139c052","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix",":ml","v9.0.0","Team:ML","backport:version","v8.18.0"],"title":"[ML]
Data frame analytics: Adds missing space between lines in delete job
modal","number":204732,"url":"https://github.com/elastic/kibana/pull/204732","mergeCommit":{"message":"[ML]
Data frame analytics: Adds missing space between lines in delete job
modal (#204732)\n\nFix for:
[#204598](https://github.com/elastic/kibana/issues/204598)\n\nAfter:\n\n<img
width=\"995\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/4c5404af-aa0d-4860-beb9-0ada9312f125\"\n/>","sha":"b50bec8f2399e50a7647872897b327fe5139c052"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204732","number":204732,"mergeCommit":{"message":"[ML]
Data frame analytics: Adds missing space between lines in delete job
modal (#204732)\n\nFix for:
[#204598](https://github.com/elastic/kibana/issues/204598)\n\nAfter:\n\n<img
width=\"995\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/4c5404af-aa0d-4860-beb9-0ada9312f125\"\n/>","sha":"b50bec8f2399e50a7647872897b327fe5139c052"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels bug Fixes for quality problems that affect the customer experience :ml release_note:fix Team:ML Team label for ML (also use :ml) v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants