Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Strings #1952

Merged
merged 7 commits into from
Dec 5, 2023
Merged

Sync Strings #1952

merged 7 commits into from
Dec 5, 2023

Conversation

ElementBot
Copy link
Collaborator

  • Update Strings from Localazy

@ElementBot ElementBot requested a review from a team as a code owner December 4, 2023 00:09
@ElementBot ElementBot requested review from ganfra and removed request for a team December 4, 2023 00:09
@ganfra
Copy link
Member

ganfra commented Dec 4, 2023

@bmarty can you check?

@bmarty
Copy link
Member

bmarty commented Dec 4, 2023

Generated code is not correct, checking what's happening here:

  <plurals name="common_member_count">
    <item quantity="%1$d tag">"one"</item>
    <item quantity="%1$d tag">"other"</item>
  </plurals>
  <plurals name="common_poll_votes_count">
    <item quantity="%d szavazat">"one"</item>
    <item quantity="%d szavazat">"other"</item>
  </plurals>

@ElementBot
Copy link
Collaborator Author

ElementBot commented Dec 4, 2023

Warnings
⚠️

features/roomdetails/impl/src/main/res/values-cs/translations.xml#L3 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

features/roomdetails/impl/src/main/res/values-ro/translations.xml#L3 - For locale "ro" (Romanian) the following quantity should also be defined: few (e.g. "2 zile")

⚠️

features/roomdetails/impl/src/main/res/values-sk/translations.xml#L3 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L214 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L219 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L224 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L229 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L214 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L219 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L224 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L229 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

Generated by 🚫 dangerJS against 24d3981

Copy link
Contributor

github-actions bot commented Dec 4, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/7gkQ4X

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 4, 2023
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e8b194) 67.72% compared to head (24d3981) 67.72%.
Report is 20 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1952   +/-   ##
========================================
  Coverage    67.72%   67.72%           
========================================
  Files         1319     1319           
  Lines        33357    33357           
  Branches      7146     7146           
========================================
  Hits         22590    22590           
  Misses        7347     7347           
  Partials      3420     3420           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bmarty bmarty merged commit b98351e into develop Dec 5, 2023
15 checks passed
@bmarty bmarty deleted the sync-localazy branch December 5, 2023 12:47
@bmarty bmarty mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants