Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incoming session verification #3733

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
+2,283 −462

Ignore temporary ktlint issue.

7b65832
Select commit
Loading
Failed to load commit list.
Draft

Incoming session verification #3733

Ignore temporary ktlint issue.
7b65832
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 25, 2024 in 1s

83.09% (+0.04%) compared to 9fb68fc

View this Pull Request on Codecov

83.09% (+0.04%) compared to 9fb68fc

Details

Codecov Report

Attention: Patch coverage is 89.96764% with 62 lines in your changes missing coverage. Please review.

Project coverage is 83.09%. Comparing base (9fb68fc) to head (7b65832).

Files with missing lines Patch % Lines
.../impl/incoming/IncomingVerificationStateMachine.kt 74.28% 16 Missing and 2 partials ⚠️
...ion/impl/incoming/IncomingVerificationPresenter.kt 85.71% 5 Missing and 7 partials ⚠️
...rifysession/impl/outgoing/VerifySelfSessionView.kt 78.94% 0 Missing and 12 partials ⚠️
.../incoming/DefaultIncomingVerificationEntryPoint.kt 0.00% 8 Missing ⚠️
...erifysession/api/IncomingVerificationEntryPoint.kt 0.00% 2 Missing ⚠️
...atures/verifysession/impl/util/StateMachineUtil.kt 66.66% 2 Missing ⚠️
.../verification/SessionVerificationRequestDetails.kt 75.00% 2 Missing ⚠️
...est/verification/FakeSessionVerificationService.kt 90.90% 2 Missing ⚠️
...ession/impl/outgoing/VerifySelfSessionPresenter.kt 96.77% 0 Missing and 1 partial ⚠️
...es/verifysession/impl/ui/VerificationBottomMenu.kt 85.71% 1 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3733      +/-   ##
===========================================
+ Coverage    83.05%   83.09%   +0.04%     
===========================================
  Files         1754     1769      +15     
  Lines        43994    44378     +384     
  Branches      5142     5202      +60     
===========================================
+ Hits         36540    36878     +338     
- Misses        5632     5669      +37     
- Partials      1822     1831       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov