Notification Improvements API part 1 #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 0013669 |
|
Kudos, SonarCloud Quality Gate passed!
|
alfogrillo
approved these changes
Jul 27, 2023
ElementX/Sources/Services/Notification/Proxy/NotificationItemProxy.swift
Show resolved
Hide resolved
alfogrillo
pushed a commit
that referenced
this pull request
Jul 27, 2023
* changes * WIP * progress * updated test * removed unused * code improvement
alfogrillo
added a commit
that referenced
this pull request
Jul 27, 2023
* Update SDK to 1.0.102-alpha * Log error * Notification Improvements API part 1 (#1410) * changes * WIP * progress * updated test * removed unused * code improvement * Process diffs as batches provided by the SDK. --------- Co-authored-by: Mauro <34335419+Velin92@users.noreply.github.com> Co-authored-by: Doug <douglase@element.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notifications now do a small sliding sync, which will allow invitations to work properly