-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification settings screen #1414
Conversation
Generated by 🚫 Danger Swift against 6185d8a |
...X/Sources/Screens/Settings/NotificationSettingsScreen/NotificationSettingsScreenModels.swift
Outdated
Show resolved
Hide resolved
...ources/Screens/Settings/NotificationSettingsScreen/NotificationSettingsScreenViewModel.swift
Outdated
Show resolved
Hide resolved
...ources/Screens/Settings/NotificationSettingsScreen/NotificationSettingsScreenViewModel.swift
Show resolved
Hide resolved
...ources/Screens/Settings/NotificationSettingsScreen/NotificationSettingsScreenViewModel.swift
Outdated
Show resolved
Hide resolved
...X/Sources/Screens/Settings/NotificationSettingsScreen/NotificationSettingsScreenModels.swift
Outdated
Show resolved
Hide resolved
...ources/Screens/Settings/NotificationSettingsScreen/NotificationSettingsScreenViewModel.swift
Outdated
Show resolved
Hide resolved
...creens/Settings/NotificationSettingsScreen/NotificationSettingsScreenViewModelProtocol.swift
Outdated
Show resolved
Hide resolved
...tX/Sources/Screens/Settings/NotificationSettingsScreen/View/NotificationSettingsScreen.swift
Outdated
Show resolved
Hide resolved
...ources/Screens/Settings/NotificationSettingsScreen/NotificationSettingsScreenViewModel.swift
Outdated
Show resolved
Hide resolved
...tX/Sources/Screens/Settings/NotificationSettingsScreen/View/NotificationSettingsScreen.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👍
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1414 +/- ##
===========================================
- Coverage 54.31% 45.45% -8.86%
===========================================
Files 393 396 +3
Lines 25413 25899 +486
Branches 12881 13137 +256
===========================================
- Hits 13802 11772 -2030
- Misses 11247 13826 +2579
+ Partials 364 301 -63
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
2c6ae72
to
6185d8a
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR implements #1024 and #1025
Notes:
notificationSettingsEnabled
feature flag@room
mentions