-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display in Notifications settings the default mode for the group and the direct chats #1024
Comments
@amshakal we have to decide what should be displayed in the global notification settings when the 2 Underride rules are different for the group chats (or for the one-to-one chats). I remind you that one rule is defined for encrypted group chats, and another is defined for unencrypted group chats In the current implementation (committed here), the displayed default value is "All" as soon as at least one of these 2 rules is enabled. If I'm correct we were waiting for the result of the new Notification settings in beta in Element-Web client. I see here 2 options:
|
When this use case happens the default notification setting displayed at the room level may be different from the global default one. For example , if
This should not be frequent. The new Web Notification settings (currently in Beta) should help to reduce the frequency |
@nimau FYI @amshakal and I agreed on the first option. A design will be provided for this banner |
@amshakal thank you, FYI we would go for the option 3. Your design satisfies entirely my initial request (which was to handle some legacy configuration which are not compatible with the new UI). We realised that this screen will appear in case of a potential server/network error when the user changes the default value. Indeed change a default value requires several requests, if one of these requests fails (and the retry fails too) we may land in the situation where configuration is incompatible. This screen will then appear, which is good to handle this edge case. We just need to update the wording to handle it correctly (a more general message would be better). Does that make sense to you? |
Sure! Happy to make changes to the copy to make it more generic. It makes sense to me. Did you have anything specific in mind? Should we say something on the lines of: "There seems to be a mismatch. Some custom settings you’ve chosen in the past are not shown here, but they’re still active.If you proceed, some of your settings may change." or "We notice a difference. Certain custom settings you chose before aren't shown here, but they're still in effect. If you continue, some settings might change." |
Giom, I also created an option 4: https://www.figma.com/file/0MMNu7cTOzLOlWb7ctTkv3/Element-X?type=design&node-id=9686%3A59522&mode=design&t=EY5fpl0LYqCRUEmW-1 |
I tried various options for android and feel like this is the best? https://www.figma.com/file/0MMNu7cTOzLOlWb7ctTkv3/Element-X?type=design&node-id=9686%3A59303&mode=design&t=EY5fpl0LYqCRUEmW-1 |
Thx @amshakal , I will check this option 4 with @nimau. There is some redundancy in my suggestion, I would be happy to let you clean it. About Android, I will have a look at it, and forward the link to the android-x issue |
Done (behind the Developer Option "Show notification settings") |
Description
Add in the notifications settings a section "Notify me for" to provide the default setting for group chats and direct chats.
The default value for group chats depends on 2 Underride rules:
.m.rule.message
and.m.rule.encrypted
. We will consider only theirenabled
attribute:The default value for group chats depends on 2 Underride rules:
.m.rule.encrypted_room_one_to_one
and.m.rule.room_one_to_one
. We will consider only theirenabled
attribute:Suggested Design
The text was updated successfully, but these errors were encountered: