Merge pull request #14 from blacksonic/master

fix(error): reponse body is readonly, not possible to reassign replyText

requestError.js

@@ -1,13 +1,18 @@
 'use strict';
+var _ = require('lodash');
 
-var SuiteRequestError = function(message, code, data) {
+var SuiteRequestError = function(message, code, response) {
   this.message = message;
   this.name = 'SuiteRequestError';
   this.code = code;
-  this.data = data || {};
-  if (!this.data.replyText) {
-    this.data.replyText = message;
+  if (response) {
+    this.data = _.cloneDeep(response.data || response);
+  } else {
+    this.data = {
+      replyText: message
+    };
   }
+
   this.stack = new Error(message).stack;
 };
 

requestError.spec.js

@@ -10,16 +10,38 @@ describe('SuiteRequestError', function() {
   });
 
   it('should store constructor parameters', function() {
-    var error = new SuiteRequestError('Invalid request', 400, { detailedMessage: 'Line too long' });
+    var error = new SuiteRequestError('Invalid request', 400, {
+      data: {
+        replyText: 'Too long',
+        detailedMessage: 'Line too long'
+      }
+    });
 
     expect(error.message).to.eql('Invalid request');
     expect(error.code).to.eql(400);
-    expect(error.data).to.eql({ detailedMessage: 'Line too long', replyText: 'Invalid request' });
+    expect(error.data).to.eql({
+      replyText: 'Too long',
+      detailedMessage: 'Line too long'
+    });
   });
 
-  it('should always contain replyText in data', function() {
+  it('should store response as is when no data attribute present', function() {
+    var error = new SuiteRequestError('Invalid request', 400, {
+      replyText: 'Too long',
+      detailedMessage: 'Line too long'
+    });
+
+    expect(error.message).to.eql('Invalid request');
+    expect(error.code).to.eql(400);
+    expect(error.data).to.eql({
+      replyText: 'Too long',
+      detailedMessage: 'Line too long'
+    });
+  });
+
+  it('should always contain data on error', function() {
     var error = new SuiteRequestError('Unauthorized');
 
-    expect(error.data.replyText).to.eql('Unauthorized');
+    expect(error.data).to.eql({ replyText: 'Unauthorized' });
   });
 });