Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Rails 7.2 #194

Merged
merged 3 commits into from
Aug 18, 2024
Merged

Support for Rails 7.2 #194

merged 3 commits into from
Aug 18, 2024

Conversation

adbelsham
Copy link
Contributor

Adds support for Rails 7.2.

@mathieujobin
Copy link
Collaborator

Can you please update the Changelog and bump the version as well?

@mathieujobin
Copy link
Collaborator

looks like 7.2 has to exclude ruby 3.0
unless we remove support for ruby 3.0 entirely as well ?

@@ -15,10 +15,13 @@ jobs:
strategy:
fail-fast: false
matrix:
rails: [7.1.1, 7.0.8, 6.1.7]
rails: [7.2.0, 7.1.1, 7.0.8, 6.1.7]
ruby: [3.3, 3.2, 3.1, 3.0.6, jruby-9.4]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think removing 3.0.6 from this line will suffice to move us forward...
not sure if we should add an explicit include for 3.0.x below or just ignore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an explicit exclude in the end.

@adbelsham
Copy link
Contributor Author

Can you please update the Changelog and bump the version as well?

This is done now.

@adbelsham
Copy link
Contributor Author

looks like 7.2 has to exclude ruby 3.0 unless we remove support for ruby 3.0 entirely as well ?

I've added an exclude line, please approve the workflows to test this has resolved the problems.

@adbelsham
Copy link
Contributor Author

Thanks for the review @mathieujobin
I've actioned your comments, please re-run the tests and let me know if any further changes required.

@mathieujobin mathieujobin merged commit 2d5b078 into emilioforrer:master Aug 18, 2024
44 checks passed
@mathieujobin
Copy link
Collaborator

released and pushed to rubygems, thanks for your contribution @adbelsham

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants