-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Rails 7.2 #194
Conversation
Can you please update the Changelog and bump the version as well? |
looks like 7.2 has to exclude ruby 3.0 |
@@ -15,10 +15,13 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
rails: [7.1.1, 7.0.8, 6.1.7] | |||
rails: [7.2.0, 7.1.1, 7.0.8, 6.1.7] | |||
ruby: [3.3, 3.2, 3.1, 3.0.6, jruby-9.4] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think removing 3.0.6 from this line will suffice to move us forward...
not sure if we should add an explicit include for 3.0.x below or just ignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added an explicit exclude in the end.
This is done now. |
I've added an exclude line, please approve the workflows to test this has resolved the problems. |
Thanks for the review @mathieujobin |
released and pushed to rubygems, thanks for your contribution @adbelsham |
Adds support for Rails 7.2.