Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Rails 7.2 #194

Merged
merged 3 commits into from
Aug 18, 2024
Merged

Support for Rails 7.2 #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
533b9b3
Support for Rails 7.2
adbelsham Aug 13, 2024
9055eb1
Exclude rails 7.2.0 and ruby 3.0.6 combination
adbelsham Aug 18, 2024
8ada7be
Update changelog and bump version
adbelsham Aug 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,13 @@ jobs:
strategy:
fail-fast: false
matrix:
rails: [7.1.1, 7.0.8, 6.1.7]
rails: [7.2.0, 7.1.1, 7.0.8, 6.1.7]
ruby: [3.3, 3.2, 3.1, 3.0.6, jruby-9.4]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think removing 3.0.6 from this line will suffice to move us forward...
not sure if we should add an explicit include for 3.0.x below or just ignore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an explicit exclude in the end.

sprockets: [3, 4]
include:
- rails: 7.2.0
ruby: 3.3
sprockets: 4
- rails: 7.1.1
ruby: 3.2
sprockets: 4
Expand All @@ -40,6 +43,9 @@ jobs:
- rails: 6.1.4
ruby: jruby-9.3
sprockets: 4
exclude:
- rails: 7.2.0
ruby: 3.0.6

env:
RAILS_VER: ${{ matrix.rails }}
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ Please have a look at the [Haml Coffee Changelog](https://github.com/netzpirat/h

## Master

## 1.26.0 - Aug 19th, 2024
- [#193][]: Add support for Rails 7.2.0

## 1.25.1 - Jul 22th, 2024
- [#192][]: Fix .hamlc is processed by jst unexpectedly (#189)

Expand Down
2 changes: 1 addition & 1 deletion haml_coffee_assets.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Gem::Specification.new do |s|
s.files = Dir.glob('{app,lib,vendor}/**/*') + %w[LICENSE README.md]

s.add_runtime_dependency 'coffee-script', '>= 2'
s.add_runtime_dependency 'railties', '>= 5.2', "< 7.2"
s.add_runtime_dependency 'railties', '>= 5.2', "< 7.3"
s.add_runtime_dependency 'sprockets', '>= 3.7'

s.add_development_dependency 'jasmine'
Expand Down
2 changes: 1 addition & 1 deletion lib/haml_coffee_assets/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# coding: UTF-8

module HamlCoffeeAssets
VERSION = '1.25.1' unless defined?(HamlCoffeeAssets::VERSION)
VERSION = '1.26.0' unless defined?(HamlCoffeeAssets::VERSION)
end
Loading