-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid exposing EnsoMultiValue getters #11642
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
82 changes: 82 additions & 0 deletions
82
.../src/test/java/org/enso/interpreter/node/expression/builtin/meta/TypeOfNodeValueTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
package org.enso.interpreter.node.expression.builtin.meta; | ||
|
||
import static org.junit.Assert.assertEquals; | ||
|
||
import com.oracle.truffle.api.RootCallTarget; | ||
import org.enso.interpreter.runtime.callable.UnresolvedConstructor; | ||
import org.enso.interpreter.runtime.callable.UnresolvedSymbol; | ||
import org.enso.interpreter.runtime.data.Type; | ||
import org.enso.interpreter.runtime.library.dispatch.TypeOfNode; | ||
import org.enso.test.utils.ContextUtils; | ||
import org.enso.test.utils.TestRootNode; | ||
import org.graalvm.polyglot.Context; | ||
import org.junit.AfterClass; | ||
import org.junit.Test; | ||
|
||
public class TypeOfNodeValueTest { | ||
private static RootCallTarget testTypesCall; | ||
private static Context ctx; | ||
|
||
private static Context ctx() { | ||
if (ctx == null) { | ||
ctx = ContextUtils.defaultContextBuilder().build(); | ||
ContextUtils.executeInContext( | ||
ctx, | ||
() -> { | ||
var node = TypeOfNode.create(); | ||
var root = | ||
new TestRootNode( | ||
(frame) -> { | ||
var arg = frame.getArguments()[0]; | ||
var t = node.findTypeOrError(arg); | ||
var all = node.findAllTypesOrNull(arg); | ||
return new Object[] {t, all}; | ||
}); | ||
root.insertChildren(node); | ||
testTypesCall = root.getCallTarget(); | ||
return null; | ||
}); | ||
} | ||
return ctx; | ||
} | ||
|
||
@AfterClass | ||
public static void disposeCtx() throws Exception { | ||
if (ctx != null) { | ||
ctx.close(); | ||
ctx = null; | ||
} | ||
} | ||
|
||
@Test | ||
public void typeOfUnresolvedConstructor() { | ||
ContextUtils.executeInContext( | ||
ctx(), | ||
() -> { | ||
var cnstr = UnresolvedConstructor.build(null, "Unknown_Name"); | ||
var arr = (Object[]) testTypesCall.call(cnstr); | ||
var type = (Type) arr[0]; | ||
var allTypes = (Type[]) arr[1]; | ||
assertEquals("Function", type.getName()); | ||
assertEquals("One array", 1, allTypes.length); | ||
assertEquals("Also function type", type, allTypes[0]); | ||
return null; | ||
}); | ||
} | ||
|
||
@Test | ||
public void typeOfUnresolvedSymbol() { | ||
ContextUtils.executeInContext( | ||
ctx(), | ||
() -> { | ||
var cnstr = UnresolvedSymbol.build("Unknown_Name", null); | ||
var arr = (Object[]) testTypesCall.call(cnstr); | ||
var type = (Type) arr[0]; | ||
var allTypes = (Type[]) arr[1]; | ||
assertEquals("Function", type.getName()); | ||
assertEquals("One array", 1, allTypes.length); | ||
assertEquals("Also function type", type, allTypes[0]); | ||
return null; | ||
}); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The c2f48f1 change should fix this error - e.g. regular
UnsupportedMessageException
without any connection to thee
will be thrown. The actuale
exception will only be sent to:will we find the stacktrace of the
AssertionError e
in the CI output?