Use Hermes Sampling Profiler API for JS Samplings #48315
+147
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67353586 |
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Dec 18, 2024
Summary: # Changelog: [Internal] Use newly added API to Hermes. In terms of Trace Events, we are going to emit: - An event for Process metadata, which will be named "Hermes" - An event for Thread metadata, on which Hermes runs - Complete Trace Event for the same Thread, which is required track to appear in the Timeline UI. I believe duration field is the key for this - Trace Event for Profile - Trace Event for ProfileChunk, which contains information about nodes and the callstack tree representation > Important: current implementation emits single ProfileChunk event. I didn't notice any issues in terms of JSON bandwidth while recording 1 minute long session in CPU-heavy application. We should re-evaluate this decision in the future and split Profiles into multiple chunks. Differential Revision: D67353586
hoxyq
force-pushed
the
export-D67353586
branch
from
f16732d to
19190f2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67353586 |
Summary: # Changelog: [Internal] Use newly added API to Hermes. In terms of Trace Events, we are going to emit: - An event for Process metadata, which will be named "Hermes" - An event for Thread metadata, on which Hermes runs - Complete Trace Event for the same Thread, which is required track to appear in the Timeline UI. I believe duration field is the key for this - Trace Event for Profile - Trace Event for ProfileChunk, which contains information about nodes and the callstack tree representation > Important: current implementation emits single ProfileChunk event. I didn't notice any issues in terms of JSON bandwidth while recording 1 minute long session in CPU-heavy application. We should re-evaluate this decision in the future and split Profiles into multiple chunks. Differential Revision: D67353586
hoxyq
force-pushed
the
export-D67353586
branch
from
19190f2 to
d2ab914
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67353586 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Use newly added API to Hermes.
In terms of Trace Events, we are going to emit:
Differential Revision: D67353586