Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous prints #20

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

hroncok
Copy link
Member

@hroncok hroncok commented Nov 14, 2024

No description provided.

@frenzymadness
Copy link
Member

OMG, I'm an idiot and two reviews are obviously not enough 🙄

@hroncok
Copy link
Member Author

hroncok commented Nov 14, 2024

FWIW I was contemplating on how to test for this, but unittest has no built-in output capturing support, so all I could figure out was to wrap every test in contextlib.redirect_stdout. I tried to enter the context manager in setUp and exit it in tearDown, but it did not work the way I tried it.

@frenzymadness
Copy link
Member

I recall there are some checks for that in pre-commit but it might be only for pdb and stuff like that.

@frenzymadness frenzymadness merged commit 60d1f79 into fedora-python:main Nov 15, 2024
9 checks passed
@hroncok hroncok deleted the noprint branch November 21, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants