Increase max size for passwords - Solving the "E-Mail address already in use" Error #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecialAro
requested changes
Mar 27, 2024
| @@ -8,7 +8,7 @@ export default class extends BaseSchema { | |||
| table.increments(); | |||
| table.string('username', 80).notNullable(); | |||
| table.string('email', 254).notNullable().unique(); | |||
| table.string('password', 60).notNullable(); | |||
| table.string('password', 254).notNullable(); | |||
There was a problem hiding this comment.
Hi!
Thank you for raising this PR. I haven't tested this yet (been having some personal issues that prevent me from reviewing and testing stuff)....
Nevertheless, we shouldn't modify migrations file, we should rather create a new one and modify that field to allow up to 254. Would you be able to create a new migration following adonisjs guides and change this PR accordingly?
Thank you so much in advance!
|
I did fix this and make a PR here but it doesn't seem to have been seen yet, @SpecialAro would you like me to make a new PR on this repo? |
|
@bioluks instead of making a new PR can you push the changes to this one instead? Thank you! |
Fix the changes that were requested of your PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
New installs are unable to register for accounts out of the box, I weren't able to do enough testing to see if it's related to password length (my one was about 40 characters). After clicking 'Create Account' it would always end up telling me "E-Mail address already in use"? I just launched the instance? Looking at issue #88 I could quickly verify it was related to the password length limiter in the code as @357up said.
Looking at the code only changing the number from 60 to 254 does the job just fine. Temporary solutions include:
for PostgreSQL databases:
and for MySQL: